Fix cudastack package parsing in jetosn-containers build command#1680
Open
mzahana wants to merge 2 commits into
Open
Fix cudastack package parsing in jetosn-containers build command#1680mzahana wants to merge 2 commits into
mzahana wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cudastack package names and add missing full variant
Summary
This PR addresses inconsistencies between the
cudastackpackage implementation and its documentation. It ensures that the package can be found using bothcudastackandcuda-stacknames and implements the missingfullvariant.Examples of Issues Fixed
1. Missing
fullvariant and hyphenated name (Documentation matches)Before:
$ jetson-containers build cuda-stack:full Error: "couldn't find package: cuda-stack:full"After:
✅ Finds
cudastack:full(alias forcuda-stack:full) and builds withWITH_CUTLASS=1.2. Base package name discovery
Before:
$ jetson-containers build cudastack Error: "couldn't find package: cudastack"After:
✅ Automatically maps to
cudastack:standard(the recommended default with TensorRT).Changes
cuda-stack) and non-hyphenated (cudastack) names now resolve to the correct variants.fullVariant: Added thecuda-stack:fullvariant which includes the CUTLASS build flag as described in the README.cuda-stack,cudastack) directly to thestandardvariant, allowing users to build a default stack with TensorRT without needing explicit tags.minimalVariant: Updated theminimalvariant to include NCCL, aligning the code with the existing documentation.TypeErrorinconfig.pywhere the globalpackagevariable was being improperly handled during list generation.Motivation
Recently, users following the
cudastack/README.mdor common naming conventions have encounteredKeyErrormessages because the internal names didn't match the documentation or expected variants. This PR aligns the code with the documentation to provide a smoother experience for users building consolidated CUDA stacks on JetPack 6.Verification Results
find_package()correctly identifiescuda-stack,cudastack,cuda-stack:full, and other variants.config.pyscript no longer crashes during package discovery.WITH_CUTLASSare correctly passed to the Dockerfile based on the chosen variant.