contrib/starlette: take into account body reading time #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note to self: unit tests does not seem to tests this path |
tests are there, they just don't run without starlette installed :) |
Create the transaction always before the body is read to avoid discrepancies between cases where the capture_body config on or off. Fix elastic#1948
xrmx
added a commit
that referenced
this pull request
Mar 20, 2024
Create the transaction always before the body is read to avoid discrepancies between cases where the capture_body config on or off. Fix #1948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Create the transaction always before the body is read to avoid discrepancies between cases where the capture_body config on or off.
Related issues
Closes #1948