Thanks to visit codestin.com
Credit goes to github.com

Skip to content

contrib/starlette: take into account body reading time #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2024
Merged

contrib/starlette: take into account body reading time #1970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions elasticapm/contrib/starlette/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
from typing import Dict, Optional

import starlette
from starlette.datastructures import Headers
from starlette.requests import Request
from starlette.routing import Match, Mount
from starlette.types import ASGIApp, Message
Expand Down Expand Up @@ -151,6 +152,10 @@ async def wrapped_send(message) -> None:
_mocked_receive = None
_request_receive = None

# begin the transaction before capturing the body to get that time accounted
trace_parent = TraceParent.from_headers(dict(Headers(scope=scope)))
self.client.begin_transaction("request", trace_parent=trace_parent)

if self.client.config.capture_body != "off":

# When we consume the body from receive, we replace the streaming
Expand Down Expand Up @@ -234,9 +239,6 @@ async def _request_started(self, request: Request) -> None:
if self.client.config.capture_body != "off":
await get_body(request)

trace_parent = TraceParent.from_headers(dict(request.headers))
self.client.begin_transaction("request", trace_parent=trace_parent)

await set_context(lambda: get_data_from_request(request, self.client.config, constants.TRANSACTION), "request")
transaction_name = self.get_route_name(request) or request.url.path
elasticapm.set_transaction_name("{} {}".format(request.method, transaction_name), override=False)
Expand Down