-
Notifications
You must be signed in to change notification settings - Fork 489
[Cloud Security] bump posture package #13582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# newer versions go on top | ||
# version map: | ||
# 1.14.x - 8.19.x, 9.1.x | ||
# 1.14.0 | 2.0.x - 8.19.x, 9.1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can have two versions like this in parallel in the main branch. If we want to make a major change, we need to bump to 2.0.0, meaning 1.14.0 will never be released. There will only be 1.14.0-previewX
versions relesed. If we want to maintain two versions in parallel, we might need to think about how to achieve it with backport branches https://www.elastic.co/docs/extend/integrations/developer-workflow-support-old-package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you're saying this should read: 2.0.x - 8.19.x, 9.1.x
without the 1.14.0
even though there are change log entries referencing 1.14.0-previewX
? i'm good either way, it's just a comment, didn't want to make the change log ambiguous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to only include 2.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the comment is not that important, the important think that we all clear on the fact that there will be no 1.14.0
released after 1.13.0
, only 2.0.0
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
History
|
Package cloud_security_posture - 2.0.0-preview01 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/2.0.0-preview01/ |
Proposed commit message
bump posture package major version to indicate a breaking change in Cloudbeat's next version which includes populating the event.outcome field with the same value from result.evaluation
Related issues