Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Apr 17, 2025

Proposed commit message

bump posture package major version to indicate a breaking change in Cloudbeat's next version which includes populating the event.outcome field with the same value from result.evaluation

Related issues

@orouz orouz requested review from maxcold and oren-zohar April 17, 2025 12:40
@orouz orouz marked this pull request as ready for review April 17, 2025 12:40
@orouz orouz requested a review from a team as a code owner April 17, 2025 12:40
@andrewkroh andrewkroh added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Apr 17, 2025
# newer versions go on top
# version map:
# 1.14.x - 8.19.x, 9.1.x
# 1.14.0 | 2.0.x - 8.19.x, 9.1.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can have two versions like this in parallel in the main branch. If we want to make a major change, we need to bump to 2.0.0, meaning 1.14.0 will never be released. There will only be 1.14.0-previewX versions relesed. If we want to maintain two versions in parallel, we might need to think about how to achieve it with backport branches https://www.elastic.co/docs/extend/integrations/developer-workflow-support-old-package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you're saying this should read: 2.0.x - 8.19.x, 9.1.x without the 1.14.0 even though there are change log entries referencing 1.14.0-previewX ? i'm good either way, it's just a comment, didn't want to make the change log ambiguous

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to only include 2.0.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the comment is not that important, the important think that we all clear on the fact that there will be no 1.14.0 released after 1.13.0, only 2.0.0

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@orouz orouz requested a review from maxcold April 24, 2025 11:22
@orouz orouz enabled auto-merge (squash) April 28, 2025 18:33
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@orouz orouz merged commit d52dbe6 into elastic:main Apr 28, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package cloud_security_posture - 2.0.0-preview01 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/2.0.0-preview01/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants