-
Notifications
You must be signed in to change notification settings - Fork 489
[Osquery] Add default saved queries #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to update this with the ECS fields all we'd have to do is put in another PR right?
@james-elastic I think it would be better to do it in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with merging for ECS mapping
I think there is no rush - 8.3 is still quite away. Who should we contact to get the mappings? Because the previous list didn't mention them. |
/test |
🌐 Coverage report
|
/test |
/test |
1 similar comment
/test |
@jsoriano it looks like we need to release a new revision of elastic-package with updated package-spec. Do you know if there are any blockers or if we can proceed with a release? |
Yes, we have to merge #3316 or similar first. We will also have to check some other new validations as the ones for the changelog links. |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: 83BC3 |
@tomsonpl As mergify failed rebasing, can you try rebasing it manually? Package Spec changes are merged now. |
@mtojek yes, I will try rebasing manually. Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@P1llus thank you :) |
Added default Saved Object (Saved Query) to Osquery Manager integration.
Screenshots