Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Apr 5, 2022

Added default Saved Object (Saved Query) to Osquery Manager integration.

Screenshots

Zrzut ekranu 2022-04-5 o 14 53 53

@tomsonpl tomsonpl added enhancement New feature or request Team:Asset Mgt Security Assets Management team [elastic/security-asset-management] v8.3.0 labels Apr 5, 2022
@tomsonpl tomsonpl requested a review from a team as a code owner April 5, 2022 12:55
@tomsonpl tomsonpl self-assigned this Apr 5, 2022
@elasticmachine
Copy link

elasticmachine commented Apr 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:58:03.877+0000

  • Duration: 19 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@james-elastic james-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we were to update this with the ECS fields all we'd have to do is put in another PR right?

@patrykkopycinski
Copy link
Contributor

@james-elastic I think it would be better to do it in this PR

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait with merging for ECS mapping

@tomsonpl
Copy link
Contributor Author

I think there is no rush - 8.3 is still quite away. Who should we contact to get the mappings? Because the previous list didn't mention them.

@patrykkopycinski
Copy link
Contributor

@james-elastic and @melissaburpo

@tomsonpl
Copy link
Contributor Author

/test

@tomsonpl tomsonpl requested a review from a team as a code owner May 10, 2022 08:56
@elasticmachine
Copy link

elasticmachine commented May 10, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.597
Classes 100.0% (1/1) 💚 3.597
Methods 78.571% (11/14) 👎 -9.675
Lines 96.933% (158/163) 👍 7.82
Conditionals 100.0% (0/0) 💚

@tomsonpl
Copy link
Contributor Author

/test

@tomsonpl
Copy link
Contributor Author

/test

1 similar comment
@tomsonpl
Copy link
Contributor Author

/test

@mtojek
Copy link
Contributor

mtojek commented May 11, 2022

@jsoriano it looks like we need to release a new revision of elastic-package with updated package-spec. Do you know if there are any blockers or if we can proceed with a release?

@jsoriano
Copy link
Member

@jsoriano it looks like we need to release a new revision of elastic-package with updated package-spec. Do you know if there are any blockers or if we can proceed with a release?

Yes, we have to merge #3316 or similar first. We will also have to check some other new validations as the ones for the changelog links.

@mtojek
Copy link
Contributor

mtojek commented May 11, 2022

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented May 11, 2022

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/16)
error: could not apply c4c34a7f... [Osquery] Add default saved queries
Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply c4c34a7f... [Osquery] Add default saved queries
Auto-merging packages/osquery_manager/manifest.yml
CONFLICT (content): Merge conflict in packages/osquery_manager/manifest.yml

err-code: 83BC3

@mtojek
Copy link
Contributor

mtojek commented May 11, 2022

@tomsonpl As mergify failed rebasing, can you try rebasing it manually? Package Spec changes are merged now.

@tomsonpl
Copy link
Contributor Author

@mtojek yes, I will try rebasing manually. Thank you :)

@tomsonpl tomsonpl requested a review from patrykkopycinski May 12, 2022 10:01
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsonpl
Copy link
Contributor Author

@P1llus thank you :)

@tomsonpl tomsonpl merged commit 765122f into elastic:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Asset Mgt Security Assets Management team [elastic/security-asset-management] v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants