-
Notifications
You must be signed in to change notification settings - Fork 489
Update README for osquery-manager #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff19ab3
to
f3a14ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a last look and saw 2 things that might need an update; but overall it looks like it's ready to go!
} | ||
``` | ||
|
||
Undefined action query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-elastic - can we add a preface here that it's an example of an error response? Maybe even just:
Error example: Undefined action query
|
||
### Supported platforms | ||
|
||
This integration supports x64_64 bit Windows, Darwin, and Linux platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be x86_64
instead of x64_64
bit?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
@melissaburpo Done |
name: osquery_manager | ||
title: Osquery Manager | ||
version: 0.2.1 | ||
version: 0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the changelog file, so it's consistent with manifest.yml.
|
||
|
||
### Exported Fields | ||
| Field | Description | Type | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you prefer to use README templates? All fields/tables could be generated. Please look at the mysql integration as example: https://raw.githubusercontent.com/elastic/integrations/master/packages/mysql/_dev/build/docs/README.md
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "0.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the previous version: 0.2.1? Would you mind filling the missing entry too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtojek Updated :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all adjustments :) Ship it please!
Update README for osquery manager.
What does this PR do?
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots