Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

james-elastic
Copy link
Contributor

Update README for osquery manager.

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Copy link
Contributor

@melissaburpo melissaburpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a last look and saw 2 things that might need an update; but overall it looks like it's ready to go!

}
```

Undefined action query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-elastic - can we add a preface here that it's an example of an error response? Maybe even just:

Error example: Undefined action query


### Supported platforms

This integration supports x64_64 bit Windows, Darwin, and Linux platforms.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be x86_64 instead of x64_64 bit?

@elasticmachine
Copy link

elasticmachine commented Apr 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #948 updated

  • Start Time: 2021-04-28T17:32:26.563+0000

  • Duration: 32 min 23 sec

  • Commit: 47acf03

Test stats 🧪

Test Results
Failed 0
Passed 1966
Skipped 3
Total 1969

Trends 🧪

Image of Build Times

Image of Tests

@james-elastic
Copy link
Contributor Author

@melissaburpo Done

name: osquery_manager
title: Osquery Manager
version: 0.2.1
version: 0.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog file, so it's consistent with manifest.yml.



### Exported Fields
| Field | Description | Type |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you prefer to use README templates? All fields/tables could be generated. Please look at the mysql integration as example: https://raw.githubusercontent.com/elastic/integrations/master/packages/mysql/_dev/build/docs/README.md

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.2.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the previous version: 0.2.1? Would you mind filling the missing entry too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtojek Updated :)

@mtojek mtojek self-requested a review April 29, 2021 14:02
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all adjustments :) Ship it please!

@james-elastic james-elastic merged commit bf6ecef into elastic:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants