fix: ESM-from-CJS import when CJK is in path #48855
Merged
+313
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39f37b9 to
7de72cb
Compare
2 tasks
codebytere
approved these changes
Nov 9, 2025
Member
|
Once merged can you open backport for |
Contributor
|
Absolutely! |
Contributor
|
Thank you! |
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #48862 |
Contributor
Author
|
@deepak1556 I have a branch in works, but I think this might actually apply cleanly if we auto-backport. |
Contributor
Author
|
Or maybe not. Now that I think line numbers in the patch will be all off. Anyway, I'm building the branch to make sure it works locally and submitting a PR in an hour or so. |
indutny-signal
added a commit
to indutny-signal/electron
that referenced
this pull request
Nov 10, 2025
5 tasks
Contributor
Author
|
@deepak1556 opened #48873 . I'm still building locally, though. |
Contributor
|
@indutny-signal has manually backported this PR to "39-x-y", please check out #48873 |
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Upstream fix: nodejs/node#60575
Checklist
npm testpassesRelease Notes
Notes: fix: ESM-from-CJS import when CJK characters are in path
cc @VerteDinde