Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ESM-from-CJS import when CJK is in path #48873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jkleinsc merged 1 commit into from
Nov 10, 2025
Merged

fix: ESM-from-CJS import when CJK is in path #48873

jkleinsc merged 1 commit into from
Nov 10, 2025

Conversation

@indutny-signal
Copy link
Contributor

@indutny-signal indutny-signal commented Nov 10, 2025 •
edited
Loading

Description of Change

Backport of #48855

Checklist

Release Notes

Notes: fix: ESM-from-CJS import when CJK characters are in path

cc @deepak1556 @codebytere

@indutny-signal indutny-signal requested a review from a team as a code owner November 10, 2025 17:18
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 10, 2025
@indutny-signal indutny-signal mentioned this pull request Nov 10, 2025
Merged
5 tasks
@trop trop bot requested a review from a team November 10, 2025 17:24
@trop trop bot added 39-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 10, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 10, 2025
@deepak1556 deepak1556 added the target/38-x-y PR should also be added to the "38-x-y" branch. label Nov 10, 2025
@jkleinsc jkleinsc merged commit 3495a3d into electron:39-x-y Nov 10, 2025
68 checks passed
@release-clerk
Copy link

release-clerk bot commented Nov 10, 2025

Release Notes Persisted

fix: ESM-from-CJS import when CJK characters are in path

@trop
Copy link
Contributor

trop bot commented Nov 10, 2025

I have automatically backported this PR to "38-x-y", please check out #48876

@indutny-signal
Copy link
Contributor Author

indutny-signal commented Nov 10, 2025

Thank you so much!

@indutny-signal indutny-signal deleted the backport/48855-to-39 branch November 10, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

39-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes target/38-x-y PR should also be added to the "38-x-y" branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@indutny-signal @jkleinsc @VerteDinde @deepak1556