Add symbol filter to outline pane #1253
Conversation
|
Regression found in global search - investigating. |
|
Looks like the regression is due to recent changes to master 😞 not this PR. |
|
Regression now fixed by #1254. Leaving this as draft as that PR should be prioritised. |
zeebok
left a comment
There was a problem hiding this comment.
It appears to work as intended!
|
@danirabbit Is this something worth progressing? I wasn't sure what icon should be used for the "Select all" button (or whether such a button is needed) |
# Conflicts fixed: # src/SymbolPane/C/CtagsSymbol.vala # src/SymbolPane/SymbolOutline.vala # src/SymbolPane/Vala/ValaSymbolItem.vala # src/Widgets/DocumentView.vala
|
@jeremypw sorry for taking a while to follow up on this! I pushed a commit with the filter icon we're using in Mail and fixing the sidebar background styles. I think for the popover I would just a regular menu here and use regular text menu items for the "select all" and "deselect" all items since those are probably more clearly communicated with text and we're not particularly constrained for space in a menu |
* Use GMenu and SimpleActions * Single select action with parameter
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected afaict. Nice job :)
The is a speculative step towards fixing issues such as #933, #809 and generally increasing the utility of the symbol pane over just searching the text.
Note: To show class methods both the "Class" and "Methods" selections must be active.
No filtering:
Filtering class properties
Searching for text "filter"