Jeremypw/use simple menu #1459
Merged
Jeremypw/use simple menu #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
added a commit
that referenced
this pull request
Aug 2, 2024
* Search symbol pane, first attempt * Implement filter tool in symbol pane * Extend range of symbol types, classify symbols * Throttle refilter; refilter on check toggled * Simplify filter; expand_all after filter * Handle Namespace type; Add ActionBar * Fix regression in search entry filtering * Delete debug warning * Inline namespace * Space out filters, add header * Reduce nesting in schedule refilter * Simplify and flatten filter func * Change stray Granite.Widget to Code.Widget * Change another stray Granite.Widgets.SourceList * Add filter icon, fix styles * Jeremypw/use simple menu (#1459) * Use GMenu and SimpleActions * Single select action with parameter * Fix lint --------- Co-authored-by: Jeremy Wootten <[email protected]> Co-authored-by: Ryan Kornheisl <[email protected]> Co-authored-by: Danielle Foré <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing @danirabbit suggestion to use a simple menu instead of CheckButtons. This required some structural changes as it proved not possible to use actions in an abstract class. It also seems that setting a parameter type on a stateful action (although allowed by syntax and compiles) causes the menu items' state indicators to malfunction.