Load sidebar folder children asynchronously after docs finished loading #1522
Conversation
# Conflicts fixed: # src/MainWindow.vala
danirabbit
left a comment
There was a problem hiding this comment.
We have a bunch of new compilation warnings about implicit begin being deprecated after making open_documen async
|
Sorry about that - I'll fix tomorrow. |
|
@jeremypw Conflicts to resolve! |
# Conflicts fixed: # src/FolderManager/FolderItem.vala
|
@zeebok Thanks for your sterling work reviewing! I have fixed the conflicts and also silenced a couple of terminal warnings. There are still some terminal warnings but they also occur in |
|
@danirabbit can you take a look at this again, please? |
There was a problem hiding this comment.
Opens fast! I do have a bunch of new criticals when running. Seems like one for each folder:
dani@mini:~/Projects/code/build$ io.elementary.code
(io.elementary.code:64562): GLib-GObject-CRITICAL **: 08:37:23.127: ../../../gobject/gsignal.c:2685: instance '0x64951fced720' has no handler with id '627'
(io.elementary.code:64562): GLib-GObject-CRITICAL **: 08:37:23.129: ../../../gobject/gsignal.c:2685: instance '0x64951fea4b70' has no handler with id '3400'
(io.elementary.code:64562): GLib-GObject-CRITICAL **: 08:37:23.129: ../../../gobject/gsignal.c:2685: instance '0x64951fec5390' has no handler with id '3516'
(io.elementary.code:64562): GLib-GObject-CRITICAL **: 08:37:23.129: ../../../gobject/gsignal.c:2685: instance '0x64951fec1320' has no handler with id '3485'
|
@danirabbit I am getting the same "no handler" messages with the master branch (on closing the app). |
|
With the latest commit and with the word completion plugin turned off, there should be no terminal warnings. There are a lot of unreviewed changes to the completion plugin pending so I'll not attempt to fix those other warnings at this point. |
Fixes #1332
A consequence of this is that documents are restored sequentially in order to more easily determine when they have all loaded. Tests with multiple large text files (10,000 lines) indicate that this is unlikely to be significant in practice.