Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremypw
Copy link
Collaborator

Fixes #1570

Also fixes expanding to focused document on startup.

  • Add a method to load children synchronously to FolderItem
  • Use synchronous method in expand to folder
  • DRY loading code in FolderItem

This means that the speed gain from #1522 is lost if a large folder needs to be loaded automatically to expand to the focused document but manually expanding large folders will still be fast.

@jeremypw jeremypw changed the title Load children synchronously when expanding sidebar to path Fix global search - load children synchronously when expanding sidebar to path May 26, 2025
@jeremypw jeremypw requested a review from a team May 26, 2025 09:42
@jeremypw jeremypw mentioned this pull request May 26, 2025
14 tasks
@jeremypw jeremypw marked this pull request as draft May 27, 2025 10:17
@jeremypw
Copy link
Collaborator Author

Converting to draft - bug found while testing.

@jeremypw jeremypw marked this pull request as ready for review May 27, 2025 10:45
@jeremypw jeremypw added the Priority: Critical e.g. security implications or reproducible crashing label May 27, 2025
Copy link
Collaborator

@leonardo-lemos leonardo-lemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@leonardo-lemos leonardo-lemos merged commit 3e488b0 into master Jun 4, 2025
6 checks passed
@leonardo-lemos leonardo-lemos deleted the jeremypw/search/fix-global branch June 4, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Critical e.g. security implications or reproducible crashing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global search does not always show all matches

4 participants