Center banner with properties and combine text with image #407
Conversation
This patch contains two (entangled) fixes: 1. Center the banner with text properties. 2. Display both the image and text banner at the same time, letting the frame pick the right one for the display type. The first change, centering with text properties, ensures that the text is smoothly centered without flickering, even if the dashboard is displayed in multiple windows at the same time (each window will center independently). I'm inserting both the text and image banner at the same time to ensure that we always get the correct banner. Before this change, creating the dashboard buffer before creating a GUI frame would display a text banner. Known issue: This patch still has to pick whether to center by the image or by the text banner. It does this at redisplay time using a display conditional, but it gets a bit confused when switching back and forth between a terminal frame and a GUI frame. fixes emacs-dashboard#386 partially fixes emacs-dashboard#388 (icons still aren't handled)
|
Cool, I think this patch would also resolve issue #197? I am currently having a disability to work with my PC. Would someone like to test and review this patch? Just randomly pining some maintainers here, @JesusMtnez @ricardoricho |
Yes, it should fix that as well (added to the list). |
|
It may also fix #292? |
|
I have enabled the CI for the PR, but I can not tested locally. I have reviewed the code and looks good to me. If it is OK for you, @jcs090218 @ricardoricho , we could merge it. Feel free to approve if you agree with it. |
|
@ricardoricho @jcs090218 did you have any change to test it? |
|
I would to like to test it before we merge this! I will probably do it next weekend (hopefully). If @ricardoricho tested and it works, feel free to merge it! ;) |
|
It works! Nice job! ❤️ 👍 |
|
This PR introduced the error: |
|
Ah... okay. I think the function Why are you using the function |
|
@jcs090218 I used |
|
Fix in #409. |
This patch contains two (entangled) fixes:
The first change, centering with text properties, ensures that the text is smoothly centered without flickering, even if the dashboard is displayed in multiple windows at the same time (each window will center independently).
I'm inserting both the text and image banner at the same time to ensure that we always get the correct banner. Before this change, creating the dashboard buffer before creating a GUI frame would display a text banner.
Known issue: This patch still has to pick whether to center by the image or by the text banner. It does this at redisplay time using a display conditional, but it gets a bit confused when switching back and forth between a terminal frame and a GUI frame.
fixes #386
fixes #197
related #388 (icons still aren't handled)