Enables overlapping contracts on OTP #8986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CT Test Results 6 files 164 suites 2h 31m 28s ⏱️ Results for commit cfa654d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
approved these changes
Oct 25, 2024
kikofernandez
commented
Oct 25, 2024
kikofernandez
commented
Oct 25, 2024
Contributor
|
In the socket module, - it's better not to use |
bmk
reviewed
Oct 25, 2024
bmk
reviewed
Oct 25, 2024
bmk
reviewed
Oct 25, 2024
kikofernandez
commented
Oct 28, 2024
bmk
approved these changes
Oct 28, 2024
c8f5225 to
cfa654d
Compare
6e3994b to
68f15ec
Compare
This was referenced Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables overlapping contracts on OTP, and fixes type specs that overlap domains whenever possible.
Some of the overlapping contracts may go away once nominal types come in.