Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kikofernandez
Copy link
Contributor

This PR fixes erroneous type specs introduced in #8986

@kikofernandez kikofernandez self-assigned this Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CT Test Results

    2 files     70 suites   1h 6m 46s ⏱️
1 556 tests 1 312 ✅ 244 💤 0 ❌
1 774 runs  1 497 ✅ 277 💤 0 ❌

Results for commit ad9f3e8.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@dgud
Copy link
Contributor

dgud commented Feb 4, 2025

There is an builtin timeout() type shouldn't we use that?

In erlang.erl

-type timeout() :: 'infinity' | non_neg_integer().

Copy link
Contributor

@RaimoNiskanen RaimoNiskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kikofernandez kikofernandez added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Feb 5, 2025
@kikofernandez kikofernandez merged commit 3b29413 into erlang:maint Feb 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants