Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical #4

merged 2 commits into from
Sep 23, 2025

Conversation

Sander0542
Copy link

Proposed Changes

Swap the ModelSupportsVaneHorizontal and ModelSupportsVaneVertical flags in the positions properties

Related Issues

Closes #3

@Sander0542 Sander0542 mentioned this pull request Aug 15, 2025
Open
antlarr
antlarr reviewed Aug 18, 2025
View reviewed changes
Copy link

@antlarr antlarr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be interesting to add a comment before each of these changes saying something like "Note that the horizontal and vertical fields are swapped in the device information returned by the MELCloud API so the next line is actually right", so that nobody reads the code in the future and thinks "This seems wrong, I'll fix it".

Appart from that, the change itself looks fine to me and should fix an issue that has been reported by MANY users of home assistant with MELCloud ac systems that only support vertical vanes.

@Sander0542
Copy link
Author

Thanks for the suggestion @antlarr. I just pushed a commit with comments in the code

@Sander0542
Copy link
Author

@erwindouna could you have a look at this PR, please?

@erwindouna erwindouna added the enhancement New feature or request label Sep 23, 2025
@erwindouna
Copy link
Owner

Thanks for submitting the PR, @Sander0542! Sorry that it got overlooked. I'll merge it and try to make a new releases anytime soon! :)

@erwindouna erwindouna merged commit 192d68d into erwindouna:master Sep 23, 2025
1 of 2 checks passed
@Sander0542
Copy link
Author

Thanks for submitting the PR, @Sander0542! Sorry that it got overlooked. I'll merge it and try to make a new releases anytime soon! :)

Thank you for merging!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@antlarr antlarr antlarr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ModelSupportsVaneVertical and ModelSupportsVaneHorizontal swapped in the API

3 participants

@Sander0542 @erwindouna @antlarr