Conversation
There was a problem hiding this comment.
Pull Request Overview
Updates Python and dependency requirements to modernize the project's compatibility matrix. The changes focus on upgrading the numpy dependency to version 2.2.0+ and dropping support for older Python versions.
- Updated numpy requirement from
<1.24to>=2.2.0to use the latest releases - Increased minimum Python version from 3.7 to 3.9 and added support for Python 3.11, 3.12, and 3.13
- Removed chainer dependency from the Makefile build process
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Updated numpy dependency and Python version requirements |
| tools/Makefile | Removed chainer.done from python target dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
I expect this will be merged before the new release in the middle of September. @sw005320. I think that if you approve it after checks are performed, it will be merged automatically. You can also activate the other auto-merge PRs by adding your user as the reviewer. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request aims to update numpy and Python version requirements. While updating dependencies is a good initiative, there are a couple of critical issues that need to be addressed. First, the new numpy version (>=2.2.0) is incompatible with the currently pinned librosa==0.9.2, which will cause installation failures. Second, removing chainer from the Makefile dependencies will lead to runtime ImportErrors, as it is still used extensively in the training loop across various tasks. I've left detailed comments on these issues.
There was a problem hiding this comment.
Code Review
This pull request updates key dependencies, most notably numpy and the supported Python versions. The numpy requirement is changed from <1.24 to >=2.2.0, and Python support is updated to require version 3.9 or newer, dropping 3.7 and 3.8. Additionally, chainer is now an optional dependency.
My main feedback concerns the significant jump in the numpy version requirement. This change could impact users with environments that rely on intermediate numpy versions and requires careful testing due to breaking changes in numpy 2.0. I've added a comment with more details in setup.py.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6221 +/- ##
=======================================
Coverage 55.82% 55.82%
=======================================
Files 884 884
Lines 84007 84007
=======================================
Hits 46900 46900
Misses 37107 37107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request effectively updates the project's dependencies, most notably numpy, and bumps the required Python version. The changes to handle the optional chainer dependency are well-implemented. I've identified a critical issue in setup.py concerning build reproducibility that should be addressed. Additionally, I've suggested improvements to the shell scripts in the CI to enhance their robustness and maintainability. Overall, these are solid updates that move the project forward.
|
This pull request is now in conflict :( |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, most notably numpy to version 2.0.0 or higher, and raises the minimum required Python version to 3.9. The changes in setup.py and devcontainer files look good. However, I found a critical issue in the new CI script that checks the numpy version. The logic is inverted and the error message is incorrect, which would cause the build to fail under the intended conditions. My review includes a suggestion to fix this.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@sw005320 This seems to be working. BTW, I found additional errors when using Python 3.12. I will be making a different PR to target related issues. |
|
Thanks! |
Notes
Fix #6213
What did you change?
This pull request updates the project's Python and dependency requirements to ensure compatibility with newer versions and to drop support for older Python versions. The key changes are focused on updating the
numpydependency and the supported Python versions insetup.py, as well as a minor update to thetools/Makefile.Dependency and compatibility updates:
numpyrequirement insetup.pytonumpy>=2.2.0, removing the previous restriction to versions below 1.24. This ensures compatibility with the latestnumpyreleases.setup.pyfrom 3.7 to 3.9, and updated the list of supported Python versions to include 3.11, 3.12, and 3.13 while removing 3.7 and 3.8.Build process update:
chainer.donefrom thepythontarget dependencies intools/Makefile, likely reflecting the project's move away from Chainer.Additional Context
The part of the code that requires
numpy<2.2(if any part is found during evaluations) will not be removed, but will raise acompatibility error.