Moving CI Test to Python 3.12#6234
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the CI testing matrix to use Python 3.12 instead of Python 3.11, aligning with Google Colab's Python version and continuing work from PR #6221.
- Updated GitHub Actions CI workflow to test against Python 3.12 instead of 3.11
- Modified documentation to reflect the Python version change in CI status badges
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ci_on_ubuntu.yml | Updated CI matrix to replace Python 3.11 with 3.12 in both test job configurations |
| README.md | Updated CI status badge table to reflect Python 3.12 instead of 3.11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request updates the CI test environment from Python 3.11 to 3.12. The change in README.md correctly updates the CI status table in the documentation to reflect this. The modification is consistent with the stated goal of the pull request. After reviewing the provided changes, I have not identified any issues of high or critical severity.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6234 +/- ##
==========================================
- Coverage 55.82% 55.82% -0.01%
==========================================
Files 884 889 +5
Lines 84013 84275 +262
==========================================
+ Hits 46903 47049 +146
- Misses 37110 37226 +116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the CI to use Python 3.12, along with necessary dependency and documentation updates. It also introduces a new script, utils/apply_code_fixes.py, to automatically fix code style issues, and applies its formatting across numerous files. While the overall changes are beneficial, the new script contains a couple of regular expression-based fixes that are overly aggressive and could introduce new style violations. I've provided specific feedback on these issues.
|
Thanks, @Fhrozen! |
Notes
This is a continuation of #6221 after observing some issues with Python 3.12 during CI tests. This is necessary because Google Colab works on 3.12, and the previous PR only targets upgrading the numpy version. In this PR, I will target these issues by raising Python 3.11 to 3.12 in CI tests.
What did you change?
This pull request updates the project's CI and documentation to replace Python 3.11 with Python 3.12 in the supported test matrix. The changes ensure that all references to Python 3.11 are removed and replaced with Python 3.12 for Ubuntu-based testing environments.
CI configuration updates:
.github/workflows/ci_on_ubuntu.ymlto test against Python 3.12 instead of Python 3.11. [1] [2]Documentation updates:
README.mdto reflect the change from Python 3.11 to Python 3.12 in the CI status badge table.