Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for PyTorch 2.9.0 by updating the installation script and documentation. The changes in README.md are correct. In tools/installers/install_torch.sh, while the logic for PyTorch 2.9.0 is consistent with the rest of the script, I've identified a significant maintainability issue due to code duplication for CUDA fallback logic. I've suggested a refactoring to improve the script's robustness and ease of future updates.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6272 +/- ##
==========================================
- Coverage 56.43% 56.24% -0.19%
==========================================
Files 897 897
Lines 84917 84917
==========================================
- Hits 47923 47762 -161
- Misses 36994 37155 +161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
what is the status of this PR? |
|
I am still checking some issues with tests raised due to updates of torchaudio. I will fix by the weekend. |
for more information, see https://pre-commit.ci
sw005320
left a comment
There was a problem hiding this comment.
LGTM, but I have some questions.
| env: | ||
| ESPNET_PYTHON_VERSION: 3.10 | ||
| TH_VERSION: 2.1.2 | ||
| TH_VERSION: 2.5.1 |
There was a problem hiding this comment.
I was using the minimum CI version. But I can use a higher version if required.
| # ESPnet: end-to-end speech processing toolkit | ||
|
|
||
| |system/pytorch ver.|2.5.1|2.6.0|2.7.1|2.8.0| | ||
| |system/pytorch ver.|2.5.1|2.7.1|2.8.0|2.9.0| |
There was a problem hiding this comment.
why 2.5.1 instead of 2.6.0?
There was a problem hiding this comment.
There are some backward incompatibilities (https://github.com/pytorch/pytorch/releases/tag/v2.6.0) between 2.5.1 and 2.6.0. I keep 2.5 to watch these incompatibilities, but I can move forward to 2.6, and remove 2.5.
|
I see. |
What did you change?
This pull request updates the supported and tested PyTorch versions across the project, including CI workflows, documentation, and installation scripts. The main focus is to add support for PyTorch 2.9.0, remove references to older versions, and ensure compatibility in CI pipelines and installation logic.
PyTorch version updates:
Updated all CI workflow matrices in
.github/workflows/ci_on_ubuntu.yml,.github/workflows/ci_on_macos.yml,.github/workflows/ci_on_windows.yml, and.github/workflows/ci_on_debian12.ymlto use PyTorch 2.7.0/2.7.1 and 2.9.0, removing 2.6.0 and ensuring the latest versions are tested. [1] [2] [3] [4] [5] [6] [7] [8]Updated the documentation table in
README.mdto reflect supported PyTorch versions: 2.5.1, 2.7.1, 2.8.0, and 2.9.0.Installation and compatibility logic:
Enhanced
tools/installers/install_torch.shto add installation logic for PyTorch 2.9.0, including CUDA version fallback and Python version checks, and updated the upper limit to 2.9.1.Updated the
TH_VERSIONenvironment variable in CI and documentation publishing workflows to match the new supported PyTorch versions. [1] [2]