Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docker Updates#6276

Merged
sw005320 merged 7 commits intoespnet:masterfrom
Fhrozen:pr-docker
Oct 27, 2025
Merged

Docker Updates#6276
sw005320 merged 7 commits intoespnet:masterfrom
Fhrozen:pr-docker

Conversation

@Fhrozen
Copy link
Member

@Fhrozen Fhrozen commented Oct 26, 2025 •
edited
Loading

This PR also fixes Docker CI build issues.

Also, Fix #6265.

What did you change?

This pull request updates the Docker build scripts and Dockerfiles to support newer versions of Ubuntu, CUDA, and related dependencies. The changes modernize the build environment, improve consistency, and update package versions for better compatibility and performance.

Base image and dependency updates:

  • Updated default base images and environment variables to use Ubuntu 24.04 and CUDA 12.6 instead of Ubuntu 22.04 and CUDA 11.7 in docker/build.sh, docker/prebuilt/gpu.dockerfile, and docker/prebuilt/runtime.dockerfile. [1] [2] [3]
  • Updated Torch version from 2.6.0 to 2.8.0 in docker/build.sh.

Dockerfile improvements and consistency:

  • Standardized Dockerfile syntax for LABEL maintainer, FROM, and environment variable assignments for clarity and consistency in docker/prebuilt/devel.dockerfile, docker/prebuilt/gpu.dockerfile, and docker/prebuilt/runtime.dockerfile. [1] [2] [3] [4]

Miniforge/Miniconda migration:

  • Migrated from Miniconda to Miniforge for Python environment setup, updating installation paths and references in both docker/prebuilt/devel.dockerfile and docker/prebuilt/runtime.dockerfile. [1] [2]

CUDA and library version upgrades:

  • Updated CUDA toolkit and associated library package versions to 12.6.x, including cublas, nccl, npp, cusparse, and nvprof, in docker/prebuilt/gpu.dockerfile.
  • Updated the Python version used in Conda installation from 3.9 to 3.11 in docker/prebuilt/devel.dockerfile.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Docker labels Oct 26, 2025
@Fhrozen Fhrozen added this to the v.202512 milestone Oct 26, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 26, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively modernizes the Docker build environment by updating to Ubuntu 24.04, CUDA 12.6, and Python 3.11, and migrating from Miniconda to Miniforge. The changes improve consistency in the Dockerfiles and update dependencies. I have one suggestion to further improve the security and best practices for adding the NVIDIA CUDA repository on Ubuntu 24.04 by avoiding the deprecated apt-key command.

@codecov
Copy link

codecov bot commented Oct 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.49%. Comparing base (7336916) to head (32ded84).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6276   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files         896      896           
  Lines       84814    84814           
=======================================
  Hits        47914    47914           
  Misses      36900    36900
Flag Coverage Δ
test_integration_espnet2 46.81% <ø> (ø)
test_integration_espnetez 36.93% <ø> (ø)
test_python_espnet2 50.93% <ø> (ø)
test_python_espnetez 12.73% <ø> (ø)
test_utils 18.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sw005320
Copy link
Contributor

sw005320 commented Oct 27, 2025

LGTM, it should be merged after #6272?

@Fhrozen
Copy link
Member Author

Fhrozen commented Oct 27, 2025

I think that merging this PR first is better. I am still debugging #6272 due to some incompatibility issues, and it may take a little longer to completely fix.

@sw005320
Copy link
Contributor

sw005320 commented Oct 27, 2025

I see.
This Docker update is for 2.8 and not for 2.9

@sw005320 sw005320 merged commit 8c394b2 into espnet:master Oct 27, 2025
32 checks passed
@Fhrozen
Copy link
Member Author

Fhrozen commented Oct 27, 2025

It will support the 2.9 updates without any additional modifications, so I think there will be no problem. But, in any case, I will check next week on the automated action.

@Fhrozen Fhrozen deleted the pr-docker branch October 27, 2025 15:39
@Fhrozen Fhrozen modified the milestones: v.202512, v.202511 Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docker size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v.202511

Development

Successfully merging this pull request may close these issues.

求助espnet镜像下载

2 participants

@Fhrozen @sw005320