Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Fix Korean translation for docs/ko/docs/tutorial/response-status-code.md#11718

Merged
alejsdev merged 2 commits into
fastapi:masterfrom
nayeonkinn:patch-2
Jun 14, 2024
Merged

🌐 Fix Korean translation for docs/ko/docs/tutorial/response-status-code.md#11718
alejsdev merged 2 commits into
fastapi:masterfrom
nayeonkinn:patch-2

Conversation

@nayeonkinn

Copy link
Copy Markdown
Contributor

I corrected minor Markdown syntax errors and removed bold formatting as per the original text.

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 9ea61ae at: https://58062c73.fastapitiangolo.pages.dev

@alejsdev alejsdev added lang-all Translations awaiting-review lang-ko Korean translations labels Jun 14, 2024

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there's one more thing.
Could you replace "당신" with "여러분" in the following text? See the discussion

https://github.com/tiangolo/fastapi/blob/9ea61ae7c8debd44c42f5dcc3d847afcebfa926b/docs/ko/docs/tutorial/response-status-code.md?plain=1#L85

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit d07724c at: https://4f2499d9.fastapitiangolo.pages.dev

@nayeonkinn nayeonkinn requested a review from hard-coders June 14, 2024 04:03
@nayeonkinn

nayeonkinn commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

@hard-coders Hi! I made the change as you suggested. Thank you for letting me know.

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@jujumilk3 jujumilk3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 😃

@alejsdev alejsdev merged commit 9d1f0e3 into fastapi:master Jun 14, 2024
@alejsdev

Copy link
Copy Markdown
Member

Thanks for the help! @nayeonkinn @hard-coders @jujumilk3 🤓 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants