🔧 Remove dead per-file-ignores entries for removed Python 3.9 tutorial files#15586
Closed
AshNicolus wants to merge 1 commit into
Closed
🔧 Remove dead per-file-ignores entries for removed Python 3.9 tutorial files#15586AshNicolus wants to merge 1 commit into
AshNicolus wants to merge 1 commit into
Conversation
The per-file-ignores in pyproject.toml still referenced docs_src/**/*_py39.py files that were removed in fastapi#14931, plus one stray docs_src/dependencies/tutorial009_py310.py entry whose file was removed in fastapi#14559. Drop the orphaned entries so the section only lists ignores that actually apply. No behavior change — ruff silently skipped these entries because the files do not exist.
Contributor
|
This PR modifies dependency files ( If you need a dependency change, please open a discussion describing what you need and why. Closing this PR automatically. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
per-file-ignoresentries inpyproject.tomlthat point todocs_src/**/*_py39.pyfiles removed in 🔥 Remove Python 3.9 specific files, no longer needed after updating translations #14931 ("Remove Python 3.9 specific files").docs_src/dependencies/tutorial009_py310.pyentry — that file was removed in ⚰️ Remove Python 3.8 from CI and remove Python 3.8 examples from source docs #14559 but the entry was reintroduced by 📝 Update source examples and docs from Python 3.9 to 3.10 #14900's mass_py39 → _py310rename.This is a config-only cleanup. Ruff silently ignores per-file rules whose paths don't exist, so behavior is unchanged; the section now only lists ignores that actually apply (41 entries → 21).
Test plan
ruff check fastapi tests docs_src scriptsoutput is identical before and after the change.pyproject.toml.