Thanks to visit codestin.com
Credit goes to github.com

Skip to content

⚰️ Remove ruff and coverage ignores for non-existing files#15610

Merged
YuriiMotov merged 4 commits into
masterfrom
remove-ruff-ignores-of-py39
May 27, 2026
Merged

⚰️ Remove ruff and coverage ignores for non-existing files#15610
YuriiMotov merged 4 commits into
masterfrom
remove-ruff-ignores-of-py39

Conversation

@YuriiMotov

@YuriiMotov YuriiMotov commented May 26, 2026

Copy link
Copy Markdown
Member

Description

py39 code examples were removed, but ignores are still here

All credits to @AshNicolus
See PR #15586 that was closed automatically due to our new rule that disallows modifying pyproject.toml by external users

To fix CI see PR #15603

Checklist

  • This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • The documentation explains the change if needed.

AshNicolus and others added 2 commits May 26, 2026 10:42
The per-file-ignores in pyproject.toml still referenced docs_src/**/*_py39.py
files that were removed in #14931, plus one stray
docs_src/dependencies/tutorial009_py310.py entry whose file was removed in
#14559. Drop the orphaned entries so the section only lists ignores that
actually apply.

No behavior change — ruff silently skipped these entries because the files
do not exist.
@YuriiMotov YuriiMotov changed the title ⚰️ Remove ruff ignores for non-existing files ⚰️ Remove ruff and coverage ignores for non-existing files May 26, 2026
@codspeed-hq

codspeed-hq Bot commented May 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks


Comparing remove-ruff-ignores-of-py39 (9e1ad05) with master (57535ef)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (ad09734) during the generation of this report, so 57535ef was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

📝 Docs preview

Last commit 9e1ad05 at: https://a18351d7.fastapitiangolo.pages.dev

Comment thread pyproject.toml
"docs_src/dependencies/tutorial008b_an_py39.py" = ["B904"]
"docs_src/dependencies/tutorial008b_py310.py" = ["B904"]
"docs_src/dependencies/tutorial008b_py39.py" = ["B904"]
"docs_src/dependencies/tutorial009_py310.py" = ["F821"]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is py310, but I checked it doesn't exist

@tiangolo tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks! 🙌

Feel free to merge when ready.

@YuriiMotov YuriiMotov merged commit a53efbc into master May 27, 2026
50 checks passed
@YuriiMotov YuriiMotov deleted the remove-ruff-ignores-of-py39 branch May 27, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants