Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for docs/ja/docs/tutorial/path-params-numeric-validations.md#1902

Merged
alejsdev merged 20 commits into
fastapi:masterfrom
SwftAlpc:translation/ja-tutorial-query-params-numeric-validations-md
Jan 15, 2024
Merged

🌐 Add Japanese translation for docs/ja/docs/tutorial/path-params-numeric-validations.md#1902
alejsdev merged 20 commits into
fastapi:masterfrom
SwftAlpc:translation/ja-tutorial-query-params-numeric-validations-md

Conversation

@SwftAlpc

@SwftAlpc SwftAlpc commented Aug 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR translates the tutorial/query-params-numeric-validations.md to Japanese.
Please review tutorial/query-params-numeric-validations.md

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 16, 2020
Closed
@codecov

codecov Bot commented Aug 16, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (9374d43) 100.00%.

❗ Current head 9374d43 differs from pull request most recent head 0ea2b7c. Consider uploading reports for the commit 0ea2b7c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #1902     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Aug 16, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit eeb5847 at: https://5f39063072903e887378199f--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 16, 2020
tokusumi
tokusumi reviewed Aug 20, 2020
View reviewed changes
Comment thread docs/ja/docs/tutorial/path-params-numeric-validations.md Outdated
Comment thread docs/ja/docs/tutorial/path-params-numeric-validations.md Outdated
Comment thread docs/ja/docs/tutorial/path-params-numeric-validations.md Outdated
@SwftAlpc

SwftAlpc commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

@tokusumi
Thanks for your review!!
I fixed it.

@github-actions

github-actions Bot commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 8857b0b at: https://5f3ea0eda968e6cc67c76502--fastapi.netlify.app

tokusumi
tokusumi approved these changes Aug 20, 2020
View reviewed changes

@tokusumi tokusumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:rocket:

@github-actions

github-actions Bot commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b8be043 at: https://5f4cb0f346d5ada9ea178e5f--fastapi.netlify.app

@github-actions

github-actions Bot commented Oct 29, 2020

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 9374d43 at: https://5f9a9e8370e646401074c1f0--fastapi.netlify.app

@tiangolo tiangolo changed the title Add tutorial/query-params-numeric-validations.md 🌐 Add Japanese translation for docs/ja/docs/tutorial/path-params-numeric-validations.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo

tiangolo commented Jun 26, 2023

Copy link
Copy Markdown
Member

📝 Docs preview for commit 0ea2b7c at: https://6499c0d492ba0c0a8379c356--fastapi.netlify.app

@alejsdev

alejsdev commented Jan 15, 2024

Copy link
Copy Markdown
Member

Thanks for your work! @SwftAlpc ✨

And thanks for your help @tokusumi 😸

@alejsdev alejsdev merged commit b73de83 into fastapi:master Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tokusumi tokusumi tokusumi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SwftAlpc @tiangolo @alejsdev @tokusumi @ryuckel