Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Japanese translation for Tutorial - Cookie Parameters#1933

Merged
tiangolo merged 19 commits into
fastapi:masterfrom
SwftAlpc:translation/ja-tutorial-cookie-params-md
Jan 9, 2021
Merged

🌐 Add Japanese translation for Tutorial - Cookie Parameters#1933
tiangolo merged 19 commits into
fastapi:masterfrom
SwftAlpc:translation/ja-tutorial-cookie-params-md

Conversation

@SwftAlpc

@SwftAlpc SwftAlpc commented Aug 20, 2020

Copy link
Copy Markdown
Contributor

This PR translates the tutorial/cookie-params.md to Japanese.
Please review tutorial/cookie-params.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 20, 2020
@codecov

codecov Bot commented Aug 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1933 (40d1b8a) into master (a7cc25e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1933   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7098e3b...40d1b8a. Read the comment docs.

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 3d92c86 at: https://5f3ebccd79ac9b1cc88d21b6--fastapi.netlify.app

Comment thread docs/ja/docs/tutorial/cookie-params.md Outdated

まず、`Cookie`をインポートします:

```Python hl_lines="1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="3"

Comment thread docs/ja/docs/tutorial/cookie-params.md Outdated

最初の値がデフォルト値で、追加の検証パラメータや注釈パラメータをすべて渡すことができます:

```Python hl_lines="7"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hl_lines="9"

@SwftAlpc

Copy link
Copy Markdown
Contributor Author

@tokusumi
Thanks for your review!
I fixed it.

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit f64d453 at: https://5f41609205ebe97956ed8abe--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 24751de at: https://5f4cbfa615bbe4bf039c8bf0--fastapi.netlify.app

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 555d89f at: https://5f9aa49974e164174407d0c0--fastapi.netlify.app

@delhi09 delhi09 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title Add tutorial/cookie-params.md. Japanese ver. 🌐 Add Japanese translation for Tutorial - Cookie Parameters Jan 9, 2021
@tiangolo

tiangolo commented Jan 9, 2021

Copy link
Copy Markdown
Member

Awesome! Thanks @SwftAlpc ! 🙇

And thank you @tokusumi and @delhi09 for the reviews! ☕

@tiangolo tiangolo merged commit 48cba16 into fastapi:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ja Japanese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants