💚 Fix badges in README and main page#3979
Conversation
…on error to return a 422
Changed to only focus on value and type errors which arise from Pydantic validation Co-authored-by: Anthony Lukach <[email protected]>
|
📝 Docs preview for commit 6a7b9f4 at: https://6159f015663db637a7488e2c--fastapi.netlify.app |
|
Awesome, thank you @ghandic! 🚀 I just updated the main page as well, the README is generated from it, so now tests should pass. Thanks for your contribution! 🍰 I also updated the Coverage upload, it's needed in PRs too to be able to measure their coverage changes. |
|
📝 Docs preview for commit 7e3ccf1 at: https://6159f1281218000f3b70ed2c--fastapi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #3979 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 410 410
Lines 10281 10281
=========================================
Hits 10281 10281 Continue to review full report at Codecov.
|
|
📝 Docs preview for commit c8008e6 at: https://6159f203bb69fce44748d893--fastapi.netlify.app |
|
You'll be measuring the PR coverage and displaying that on the main page though. I did have a look to see if there was some filtering that could be done for that badge but couldn't see anything at a first pass. I'll continue to look 👍🏻 |
|
We could add flags conditional of whether it is a PR or a push and then filter by that flag for the badge. I'll make another PR today to fix, that way you'll keep the codecov run for PR to check but also have the coverage % accurate on the readme |
Fixing workflow badge to point to the master branch and not forks with PR. Looking into how to do the same for codecov