[SQL] Include struct hash in struct name #5512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #5390 by modifying how struct types generate their string representation to include the hash value. This change enables the compiler to distinguish between anonymous and named structs with identical field structures, which was causing conflicts in the reported issue.
Changes:
- Modified
DBSPTypeStruct.toString()to append the hash value to the struct name output - Added test case
issue5390()that creates user-defined types with similar structures (one using anonymous ROW, one using named user-defined type) to verify the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sql-to-dbsp-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/CatalogTests.java | Adds regression test for issue #5390 with user-defined types containing similar nested structures |
| sql-to-dbsp-compiler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/ir/type/derived/DBSPTypeStruct.java | Updates struct string representation to include hash value for proper differentiation |
Comment on lines
+286
to
+289
| .append(" ") | ||
| .append(this.name.name()) | ||
| .append(" ") | ||
| .append(this.hashName); |
There was a problem hiding this comment.
The addition of spaces around the struct name and hash creates output like struct name hash. This spacing pattern may not match the expected format. Consider removing the extra spaces or documenting why this specific spacing is required.
rivudhk
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5390
This affects how the hash of a structure name is computed; this change makes it possible to distinguish between anonymous and named structs that are otherwise identical, which occur in the example program.