Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SQL] Include struct hash in struct name #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Jan 27, 2026
Merged

[SQL] Include struct hash in struct name #5512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...piler/SQL-compiler/src/main/java/org/dbsp/sqlCompiler/ir/type/derived/DBSPTypeStruct.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,10 @@ public void accept(InnerVisitor visitor) {
public IIndentStream toString(IIndentStream builder) {
return builder.append("struct ")
.append(this.mayBeNull ? "?" : "")
.append(this.name.name());
.append(" ")
.append(this.name.name())
.append(" ")
.append(this.hashName);
Comment on lines +286 to +289
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of spaces around the struct name and hash creates output like struct name hash. This spacing pattern may not match the expected format. Consider removing the extra spaces or documenting why this specific spacing is required.

Copilot uses AI. Check for mistakes.
}

/** Generate a tuple type by ignoring the struct and field names. */
Expand Down
14 changes: 14 additions & 0 deletions ...p-compiler/SQL-compiler/src/test/java/org/dbsp/sqlCompiler/compiler/sql/CatalogTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,4 +890,18 @@ CREATE TABLE example (
z ROW(x INT, y INT) NOT NULL default ROW(1, 2)
);""");
}


@Test
public void issue5390() {
this.getCCS("""
CREATE TYPE user_def AS(i1 INT);
CREATE TYPE user_def_row AS (val ROW(i1 INT));
CREATE TYPE user_def_udt AS (val user_def);

CREATE MATERIALIZED VIEW v AS SELECT
SAFE_CAST(NULL AS user_def_row) AS to_row,
SAFE_CAST(NULL AS user_def_udt) AS to_udt
;""");
}
}
Loading