QuickOpenModal #4464

wldcordeiro · 2017-10-22T01:35:35Z

Associated Issue: #3178

Summary of Changes

Merges the three modals (symbols, sources and goto line) into one GotoAnywhere modal

jasonLaster · 2017-10-22T01:36:51Z

src/actions/goto-anywhere.js

 import type { ThunkArgs } from "./types";

-export function setSourceSearchQuery(queryString: string) {
+export function setGotoAnywhereQuery(queryString: string) {


lol.. not sure about gotoanywhere what does atom/code call this modal?

Sublime called it GotoAnything, Atom doesn't specifically call it out by a name in their Flight Manual.

jasonLaster · 2017-10-22T01:37:46Z

src/utils/gotoQuery.js

+        return { type: "terms", query };
+      case ":":
+        return { type: "goto", query };
+    }


how about a map here:

const modifiers = { "@": { type: "symbols", query } }

wldcordeiro · 2017-10-22T20:21:19Z

src/components/GotoAnywhereModal.js

+
+import type { SelectSourceOptions } from "../actions/sources";
+import type { ResultListItem, ResultListItems } from "./shared/ResultList";
+import type { FormattedSymbolDeclarations } from "../utils/goto-anywhere-formatters";


Eslint hates this line but prettier keeps formatting it this way. 😠

wldcordeiro · 2017-10-22T23:21:06Z

package.json

-    "snapshotSerializers": ["jest-serializer-babel-ast"],
+    "snapshotSerializers": [
+      "jest-serializer-babel-ast",
+      "enzyme-to-json/serializer"


This lets me do snapshot testing on components rendered with Enzyme's mount

wldcordeiro · 2017-10-22T23:46:15Z

src/components/GotoAnywhereModal.js

+
+type Props = {
+  enabled: boolean,
+  sources: Array<Object>,


Do we have fixtures anywhere for sources, selectedSource, and symbols @jasonLaster?

wldcordeiro · 2017-10-22T23:49:04Z

Follow-ups:

Add more tests to QuickOpenModal.spec.js
update ShortcutsModal to reflect new options

wldcordeiro · 2017-10-23T03:35:07Z

circle.yml

  override:
    - yarn install
-    - yarn global add flow-coverage-report
+    - yarn global add flow-coverage-report@0.3.0


Circle would fail to find a version of flow-coverage-report and fail out. 🙁 When I ran this locally it found the version. I noticed a couple other PRs also had this failure though.

jasonLaster

Wow! so much good stuff!

All of my suggestions are style based. Take them or leave them :)

I'm really tempted to land it now and refactor in a second pass. Up to you...

jasonLaster · 2017-10-25T03:00:28Z

src/components/shared/SearchInput.js

+    if (this.$input.value != "") {
+      this.$input.setSelectionRange(
+        this.$input.value.length + 1,
+        this.$input.value.length + 1


what does this do?

Without this when it opens with the modifiers (@/#etc) the cursor would be before the modifier and not after it.

jasonLaster · 2017-10-25T03:00:45Z

src/components/tests/QuickOpenModal.spec.js

+    wrapper.setProps({ enabled: true });
+    expect(wrapper).toMatchSnapshot();
+  });
+});


jasonLaster · 2017-10-25T03:02:02Z

src/reducers/ui.js


 export type UIState = {
  activeSearch: ?ActiveSearchType,
+  quickOpenEnabled: boolean,


hmm, it might be nice to move this to the quickOpen reducer.

I had waffled on that a bit. I had considered it for a bit but figured I could move it. Since it was whether it appeared or not it seemed UIish but it was the quick open's state heh.

jasonLaster · 2017-10-25T03:02:56Z

src/test/mochitest/browser_dbg-quick-open.js

+    "quickOpen enabled"
+  );
+  pressKey(dbg, "Escape");
+  is(


can we dry these up w/ helper methods

assertEnabled assertDisiabled

jasonLaster · 2017-10-25T03:03:17Z

src/test/mochitest/browser_dbg-quick-open.js

+  // Testing variable search
+  pressKey(dbg, "quickOpen");
+  type(dbg, "sw2");
+  pressKey(dbg, "Enter");


can we dry this up too?

Just the open -> query -> enter pattern?

jasonLaster · 2017-10-25T03:07:43Z