Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Avoid physics query slowdown over time by rebuilding broadphase every frame #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxCWhitehead merged 1 commit into from
Apr 6, 2024
Merged

fix: Avoid physics query slowdown over time by rebuilding broadphase every frame #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/core/physics/collisions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,13 @@ impl<'a> CollisionWorld<'a> {
&collision_cache,
);

// Force a full rebuild of broadphase
// PhysicsPipeline step should incrementally update it, but due to an issue with
// incrementally rebalancing BVH in parry2d, the tree becomes unbalanced and query perf tanks.
// Rebuilding it every frame is quite fast for our game, and avoids this issue.
// https://github.com/fishfolk/jumpy/issues/961
query_pipeline.update(rigid_body_set, collider_set);

// Iter on each dynamic rigid-bodies that moved.
for rigid_body_handle in islands.active_dynamic_bodies() {
let rigid_body = rigid_body_set.get_mut(*rigid_body_handle).unwrap();
Expand Down