[Property Editor] Can filter properties in the Property Editor#9022
[Property Editor] Can filter properties in the Property Editor#9022elliette merged 14 commits intoflutter:masterfrom
Conversation
|
DBC, this is actually not search, but filter. The search function leaves the existing data set and allows users to traverse through for matches. Filter removes all parts of the data set that do not match the filter query. See the logging screen for an example of using the |
...evtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
Outdated
Show resolved
Hide resolved
...evtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
Outdated
Show resolved
Hide resolved
...evtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
Outdated
Show resolved
Hide resolved
...ges/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_types.dart
Outdated
Show resolved
Hide resolved
| return Column( | ||
| children: <Widget>[ | ||
| _FilterControls(controller: widget.controller), | ||
| if (widget.editableProperties.isEmpty) |
There was a problem hiding this comment.
what if editableProperties is empty and the filter query is empty? In this case, this message may not make sense
There was a problem hiding this comment.
That is actually handled before we get here - if there are no editable properties at all we display a message instead of rendering the _PropertiesList:
Work towards #8955, #1948
Note: Filed #9006 for search input mis-alignment