[Property Editor] Add filters for set and default values#9083
[Property Editor] Add filters for set and default values#9083elliette merged 6 commits intoflutter:masterfrom
Conversation
| /// the filter state. | ||
| class FilterDialog<T> extends StatefulWidget { | ||
| FilterDialog({super.key, required this.controller}) | ||
| : assert(controller.queryFilterArgs.isNotEmpty), |
There was a problem hiding this comment.
This was throwing an assert error, and as far as I can tell we are not expecting the queryFiltersArgs to be non-empty anywhere in this widget.
|
I can see why a user might want to see only properties that are set, but what is the use case where a user would only want to see properties that are set to the default value? |
...evtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart
Outdated
Show resolved
Hide resolved
I think this is mostly useful in conjunction with the "set" filter - a user could filter to all set values that match the default value to see which arguments are redundant and can be removed. (But the more useful filter is certainly the "set" one, I also thought it would look a little strange to have a Filter dialog with only one filter in it) |
Counter argument to this is that this can already be caught today with a lint.
I think having only one filter is fine as long as that filter is a relevant user journey. I'd argue that we should start with what we know is useful and let users ask for things we are missing rather than adding options that a user "might" want at some point. |
SG! Removed the "default" filter |
Fixes #8955
Follow up to #9022
Adds a button to the filter input that opens the filter dialog with two options: