This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix noop toString() diagnostics #35100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 2, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Aug 5, 2022
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 8, 2022
Flutter engine fixes: flutter/engine#35100 Flutter tools fixes: flutter/flutter#108836 Flutter plugins test fixes: flutter/plugins#6173 Flutter plugins script fixes: flutter/plugins#6175 Flutter plugins testing/scenario_app: flutter/engine#35165 (Internal) linter test execution fixes: cl/464897186 Change-Id: Ica7cbcba7599d1367fc67e088ff634398a160df7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253501 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix diagnostics that will get flagged in the next Dart SDK roll.
See breakage:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8806923775196938273/+/u/analyze_flutter_engine/stdout
Source Linter DEP bump: https://dart-review.googlesource.com/c/sdk/+/253501
/cc @a14n @srawlins
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.