Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher] fix noop toString() diagnostics #6173

Merged
merged 1 commit into from
Aug 2, 2022
Merged

[url_launcher] fix noop toString() diagnostics #6173

merged 1 commit into from
Aug 2, 2022

Conversation

pq
Copy link
Contributor

@pq pq commented Aug 2, 2022 •
edited
Loading

Fix diagnostics that will get flagged in the next Dart SDK roll.

See breakage:

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8806923775196938257/+/u/flutter_test_flutter_plugins/stdout

Source Linter DEP bump: https://dart-review.googlesource.com/c/sdk/+/253501

/cc @a14n @srawlins

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from stuartmorgan-g as a code owner August 2, 2022 21:17
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@pq pq requested a review from goderbauer August 2, 2022 21:17
@pq pq changed the title fix noop toString() diagnostics [url_launcher] fix noop toString() diagnostics Aug 2, 2022
goderbauer
goderbauer approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pq
Copy link
Contributor Author

pq commented Aug 2, 2022 •
edited
Loading

@goderbauer, @stuartmorgan : could you advise about the version check failure reported by the "publishable" bot?

@pq pq mentioned this pull request Aug 2, 2022
Merged
@goderbauer
Copy link
Member

Th exceptions to requiring a new version are listed here: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version. I think this PR qualifies for the following exception:

PRs that only affect local development (e.g., changes to ignored lints).

I added the exception label and restarted the check.

@goderbauer goderbauer added the override: no versioning needed Override the check requiring version bumps for most changes label Aug 2, 2022
@pq pq added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Aug 2, 2022
@pq
Copy link
Contributor Author

pq commented Aug 2, 2022

I think for the same reason, we don't need a changelog. (Tag added.)

@pq pq added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 2, 2022
@auto-submit auto-submit bot merged commit a054dc6 into flutter:main Aug 2, 2022
@pq pq deleted the noop_toStrings branch August 2, 2022 23:27
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Aug 3, 2022 •
edited
Loading

Th exceptions to requiring a new version are listed here: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version. I think this PR qualifies for the following exception:

PRs that only affect local development (e.g., changes to ignored lints).

I added the exception label and restarted the check.

It's not a big deal in this case, but for future reference this did not qualify. This changed actual production code run by clients of the package, and thus should have had a version change, because it could have been wrong. Extremely unlikely here, but possible. "I'm sure this won't break anything" is a famously common description of changes that break things 🙂

That exception is for things like:

// ignore: some_lint

because that comment does not have any impact on the code as run by clients.

@pq
Copy link
Contributor Author

pq commented Aug 3, 2022

Thanks for chiming in @stuartmorgan!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2022
@engine-flutter-autoroll
a054dc639 [url_launcher] fix noop toString() diagnostics (flutter/plu…
1740922 
…gins#6173)
@goderbauer
Copy link
Member

Noted!

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 8, 2022
@pq
linter 1.27.0
11e2bf9 
Flutter engine fixes: flutter/engine#35100
Flutter tools fixes: flutter/flutter#108836
Flutter plugins test fixes: flutter/plugins#6173
Flutter plugins script fixes: flutter/plugins#6175
Flutter plugins testing/scenario_app: flutter/engine#35165

(Internal) linter test execution fixes: cl/464897186


Change-Id: Ica7cbcba7599d1367fc67e088ff634398a160df7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253501
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
yutaaraki-toydium pushed a commit to yutaaraki-toydium/plugins that referenced this pull request Aug 12, 2022
@pq @yutaaraki-toydium
[url_launcher] fix noop toString() diagnostics (flutter#6173)
d5affc9
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@pq @mauricioluz
[url_launcher] fix noop toString() diagnostics (flutter#6173)
81c5e89
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: url_launcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pq @goderbauer @stuartmorgan-g