Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Refactor PlatformHandler's tests #37820

Merged
merged 6 commits into from
Nov 22, 2022
Merged

[Windows] Refactor PlatformHandler's tests #37820

merged 6 commits into from
Nov 22, 2022

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Nov 21, 2022 •
edited
Loading

This simplifies the PlatformHandler tests:

  1. Send and verify JSON strings instead of serializing objects
  2. Replaced stubs with mocks

Some tests were renamed or added:

Before After Notes
GettingTextCallsThrough GetClipboardData
RejectsGettingUnknownTypes GetClipboardDataRejectsUnknownContentType
❌ GetClipboardDataReportsOpenFailure New test
GetHasStringsCallsThrough, HasStringsSuccessWithoutStrings ClipboardHasStrings These tests were merged
HasStringsSuccessWithStrings ClipboardHasStringsReturnsFalse
RejectsGetHasStringsOnUnknownTypes ClipboardHasStringsRejectsUnknownContentType
HasStringsAccessDeniedReturnsFalseWithoutError ClipboardHasStringsIgnoresPermissionErrors
HasStringsError ClipboardHasStringsReportsErrors
SettingTextCallsThrough ClipboardSetData
RejectsSettingUnknownTypes ClipboardSetDataUnknownType
❌ ClipboardSetDataReportsOpenFailure New test
❌ ClipboardSetDataReportsSetDataFailure New test
PlayingSystemSoundCallsThrough PlaySystemSound
ReleaseClipboard ❌ Removed. Other tests verify mocks are destroyed.

Part of flutter/flutter#115611

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma marked this pull request as ready for review November 21, 2022 23:21
dkwingsmt
dkwingsmt reviewed Nov 22, 2022
View reviewed changes
dkwingsmt
dkwingsmt approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice change!

yaakovschectman
yaakovschectman approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2022
@auto-submit auto-submit bot merged commit f75287a into flutter:main Nov 22, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
f75287af0 [Windows] Refactor PlatformHandler's tests (flutter/engin…
d1577bf 
…e#37820)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 4bf16c369bfc to f75287af0b19 (2 revisions) (#…
b7023e8 
…115891)

* 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843)

* f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 4bf16c369bfc to f75287af0b19 (2 revisions) (f…
151dd46 
…lutter#115891)

* 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843)

* f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 4bf16c369bfc to f75287af0b19 (2 revisions) (f…
aa0242a 
…lutter#115891)

* 8e458a2b6 [Impeller] Set color attachment pixel format to RGBA on OpenGLES backend (flutter/engine#37843)

* f75287af0 [Windows] Refactor `PlatformHandler`'s tests (flutter/engine#37820)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

@justinmc justinmc Awaiting requested review from justinmc

@a-wallen a-wallen Awaiting requested review from a-wallen

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
Multi Window
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic-sharma @dkwingsmt @yaakovschectman