This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] cache sample and stencil params #38829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
On flutter/gallery, this reduces the amount of scripting time reporting when resizing by about 25%: Before: After: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 14, 2023
…118505) * 9204745e5 [web] remove runtime effect check (flutter/engine#38832) * 7dc5e7efa [web] cache sample and stencil params (flutter/engine#38829)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#118505) * 9204745e5 [web] remove runtime effect check (flutter/engine#38832) * 7dc5e7efa [web] cache sample and stencil params (flutter/engine#38829)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
* [web] cache sample and stencil params * test and style * Update canvaskit_api_test.dart * Update canvaskit_api_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#117934
Now the only expensive part is some style recalc/relayout whenever the canvas is eventually resized.
Before
#After