Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] remove runtime effect check #38832

Merged
merged 1 commit into from
Jan 13, 2023
Merged

[web] remove runtime effect check #38832

merged 1 commit into from
Jan 13, 2023

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jan 13, 2023 •
edited
Loading

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jan 13, 2023
yjbanov
yjbanov approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 13, 2023
@auto-submit auto-submit bot merged commit 9204745 into flutter:main Jan 13, 2023
@jonahwilliams jonahwilliams mentioned this pull request Jan 13, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 14, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
9204745e5 [web] remove runtime effect check (flutter/engine#38832)
2de4fb4
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 14, 2023
@engine-flutter-autoroll
Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (#…
da5f8cf 
…118505)

* 9204745e5 [web] remove runtime effect check (flutter/engine#38832)

* 7dc5e7efa [web] cache sample and stencil params (flutter/engine#38829)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from a512cebdcd30 to 7dc5e7efa66a (2 revisions) (f…
8ff978d 
…lutter#118505)

* 9204745e5 [web] remove runtime effect check (flutter/engine#38832)

* 7dc5e7efa [web] cache sample and stencil params (flutter/engine#38829)
ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023
@jonahwilliams
[web] remove runtime effect check (flutter#38832)
30e3e3f
@feinstein
Copy link

The docs on InkSparkle mention it's not supported on CanvasKit and we should look this issue. But the issue is closed, so shouldn't the docs be updated?

@jonahwilliams
Copy link
Member Author

yes, this is all done and should work. Thanks for the heads up on the docs, we missed that one.

@jonahwilliams jonahwilliams deleted the remove_runtime_effect_check branch June 1, 2023 02:01
@feinstein
Copy link

My pleasure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Remove RuntimeEffect availability check once the transition to engine built canvaskit is complete
3 participants
@jonahwilliams @feinstein @yjbanov