Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests #39209

Merged
merged 4 commits into from
Jan 30, 2023
Merged

[Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests #39209

merged 4 commits into from
Jan 30, 2023

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 27, 2023 •
edited
Loading

This makes the Windows keyboard tests use the new FlutterWindowsEngineBuilder to create an engine to test against. This will make testing easier when the keyboard & text plugins are moved up from the view to the engine.

Part of flutter/flutter#115611

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title [Windows] Refactor the Windows unit tests [Windows] Refactor the keyboard unit tests Jan 27, 2023
@loic-sharma loic-sharma force-pushed the windows_refactor_keyboard_tests branch from b59b8ea to ddb41c5 Compare January 27, 2023 23:27
@loic-sharma loic-sharma changed the title [Windows] Refactor the keyboard unit tests [Windows] Move the keyboard unit tests to 'FlutterWindowsEngineBuilder' Jan 28, 2023
@loic-sharma loic-sharma changed the title [Windows] Move the keyboard unit tests to 'FlutterWindowsEngineBuilder' [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests Jan 28, 2023
@loic-sharma loic-sharma marked this pull request as ready for review January 28, 2023 02:17
dkwingsmt
dkwingsmt approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit auto-submit bot merged commit daa8eeb into flutter:main Jan 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
daa8eeb7f [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard uni…
306b828 
…t tests (flutter/engine#39209)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (#…
865dc5c 
…119584)

* 033514b3d [Windows] Remove dead code from FlutterWindow tests (flutter/engine#39216)

* daa8eeb7f [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests (flutter/engine#39209)
cbracken
cbracken reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this earlier but a very hearty LGTM! Love it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cbracken cbracken cbracken left review comments

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loic-sharma @cbracken @dkwingsmt @yaakovschectman