Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update all plugins minimum from iOS 9 to iOS 11 #101965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #101959
jmagman opened this issue Apr 15, 2022 · 5 comments
Closed
Tracked by #101959

Update all plugins minimum from iOS 9 to iOS 11 #101965

jmagman opened this issue Apr 15, 2022 · 5 comments
Labels
P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically

Comments

@jmagman
Copy link
Member

jmagman commented Apr 15, 2022

Increase plugin minimum target iOS version from 9.0 to 11.0 flutter.dev/go/rfc-32-bit-ios-unsupported.

To paraphrase Stuart from #84198, the last time this was done:

Once Flutter stable no longer supports [iOS 9], we should update all the 1P plugins to match. This will eliminate the issue of deprecation warnings from the plugins in the now-common case where people build with projects that use [iOS 11] as the minimum.

Currently all of our plugins support [iOS 9] so this will affect every plugin that supports iOS, although we'll only need to update the deprecated plugins if at some point we have CI issues with the [iOS 9] support.

When we do this, we should make sure the READMEs prominently list the minimum iOS version (see also #34999)

Example: flutter/plugins#4327

Blocked by #101961

Also run app migrator #101960 by building all example projects.

@jmagman jmagman added platform-ios iOS applications specifically plugin P3 Issues that are less important to the Flutter project labels Apr 15, 2022
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Apr 15, 2022

Also from the previous issue:

We should probably also update the minimum Flutter version at the same time so that we guarantee that nobody trying to build for [iOS 9] with an older version of Flutter resolves to a newer version of the plugin.

A nice bonus since last time is that for any plugin we've federated (which is most of them now) we only need to increase the minimum version on the iOS implementation package, so people still using old versions of Flutter will still be able to get fixes in other packages.

(Which means the README updates will actually be slightly misleading, since the overall plugin actually will have some support for older versions of iOS, but that's fine.)

@jmagman
Copy link
Member Author

jmagman commented May 16, 2022

Clean up availability and deprecation pragmas, see flutter/plugins#5765

@jmagman
Copy link
Member Author

jmagman commented Aug 31, 2022

This should to wait until the plugin package n-2 stable minimum version is > Flutter 3.1 as that's the first stable containing 1756ccc.
Example, this set it to 2.10: flutter/plugins#6340

@stuartmorgan-g
Copy link
Contributor

It's fine to update all the iOS implementation packages to 3.3 now as part of upping the minimum iOS version. The N-2 tests are just to prevent accidentally breaking people using older versions by publishing something that the resolver will give them but then doesn't compile. We only commit to activelysupporting current stable.

@stuartmorgan-g stuartmorgan-g added package flutter/packages repository. See also p: labels. and removed plugin labels Mar 6, 2023
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue May 8, 2023
path_provider part of flutter/flutter#101965.

Built the `path_provider` and `path_provider_foundation` example projects on Flutter 3.7. and let the tool auto-migrate various Xcode project/Podfile files.
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue May 8, 2023
shared_preferences part of flutter/flutter#101965.

Built the `shared_preferences` and `shared_preferences_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

No Flutter version update was necessary, as `shared_preferences_foundation` already has a minimum of 3.3.
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue May 8, 2023
shared_preferences part of flutter/flutter#101965.

Built the `shared_preferences` and `shared_preferences_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

No Flutter version update was necessary, as `shared_preferences_foundation` already has a minimum of 3.3.
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue May 8, 2023
quick_actions part of flutter/flutter#101965.

Built the `quick_actions` and `quick_actions_ios` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of `quick_actions_ios` to 3.3, where
the iOS minimum version was raised to 11.
stuartmorgan-g added a commit to stuartmorgan-g/packages that referenced this issue May 8, 2023
quick_actions part of flutter/flutter#101965.

Built the `quick_actions` and `quick_actions_ios` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of `quick_actions_ios` to 3.3, where
the iOS minimum version was raised to 11.
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 8, 2023
path_provider part of flutter/flutter#101965.

Built the `path_provider` and `path_provider_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

No Flutter version update was necessary, as `path_provider_foundation` already has a minimum of 3.3.
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 8, 2023
shared_preferences part of flutter/flutter#101965.

Built the `shared_preferences` and `shared_preferences_foundation` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

No Flutter version update was necessary, as `shared_preferences_foundation` already has a minimum of 3.3.
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 8, 2023
quick_actions part of flutter/flutter#101965.

Built the `quick_actions` and `quick_actions_ios` example projects on Flutter 3.7 and let the tool auto-migrate various Xcode project/Podfile files. (These changes don't affect plugin clients, so I used the latest stable instead of 3.3.)

Updated the minimum Flutter version of `quick_actions_ios` to 3.3, where the iOS minimum version was raised to 11.
auto-submit bot pushed a commit to flutter/packages that referenced this issue May 10, 2023
- Runs iOS builds with current stable, landing the auto-migration changes. This includes automatically updating the example apps to require iOS 11+.
- Updates the pigeon test plugins to only support iOS 11+.

The are example-/test-only changes, so don't affect clients of these packages.

See flutter/flutter#101965
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically
Projects
None yet
Development

No branches or pull requests

2 participants