-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera] Bump minimum Flutter version and iOS deployment target #4327
Conversation
@@ -19,7 +19,9 @@ First, add `camera` as a [dependency in your pubspec.yaml file](https://flutter. | |||
|
|||
### iOS | |||
|
|||
iOS 10.0 of higher is needed to use the camera plugin. If compiling for any version lower than 10.0 make sure to check the iOS version before using the camera plugin. For example, using the [device_info_plus](https://pub.dev/packages/device_info_plus) plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stared at "If compiling for any version lower than 10.0 make sure to check the iOS version before using the camera plugin" for awhile before I understood what it was trying to say.
@@ -25,6 +25,6 @@ | |||
<string>arm64</string> | |||
</array> | |||
<key>MinimumOSVersion</key> | |||
<string>8.0</string> | |||
<string>9.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done automatically via flutter/flutter#85174 by just flutter build
ing the example project.
@@ -504,7 +504,7 @@ | |||
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE; | |||
GCC_WARN_UNUSED_FUNCTION = YES; | |||
GCC_WARN_UNUSED_VARIABLE = YES; | |||
IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
IPHONEOS_DEPLOYMENT_TARGET = 9.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, done automatically via flutter/flutter#85174.
@stuartmorgan Do you think this change is too soon considering 2.5 stable only dropped this week? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan Do you think this change is too soon considering 2.5 stable only dropped this week?
No, this is fine; we only guarantee compatibility with the latest stable version for 1P plugins. And the plugin updates will also only drop this week 🙂
One small nit: for clarity's sake we should probably update the example
app's minimum Flutter SDK version too. Looks like we forgot that during NNBD migration, but this is a good opportunity to clean it up. (It's not a big deal if we don't obviously, but I assume the error message will be clearer when trying to run the example with an older version if we do.)
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
* master: [webview_flutter] Add download listener to Android webview (flutter#4322) [video_player] add support for content-uri based videos (flutter#4330) [webview_flutter] Implementation of the webview_flutter_platform_interface package (flutter#4302) [camera] Bump minimum Flutter version and iOS deployment target (flutter#4327) [video_player] interface: add support for content-uri based videos (android only) (flutter#4307) Ignore unnecessary_import in legacy analysis options (flutter#4129) [ci] Enable the new Windows targets (flutter#4325) # Conflicts: # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java # packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewBuilder.java
Flutter apps run on 2.4.0-0.0.pre and later will be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable and iOS 8 support has been dropped, change the plugin minimum iOS version to
9.0
.Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption #3324 (there's recent precedent).
Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.
Camera part of flutter/flutter#84198
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).