Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Skia Gold support to tests for package:integration_test #72045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiahaog opened this issue Dec 10, 2020 · 2 comments · Fixed by #159233
Closed

Add Skia Gold support to tests for package:integration_test #72045

jiahaog opened this issue Dec 10, 2020 · 2 comments · Fixed by #159233
Assignees
@matanlurey
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: proposal A detailed proposal for a change to Flutter f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. good first issue Relatively approachable for first-time contributors P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@jiahaog
Copy link
Member

jiahaog commented Dec 10, 2020

As mentioned in #70368 (comment), it would be better if we could have Skia Gold integration for the internal package tests.
@jiahaog jiahaog added the f: integration_test The flutter/packages/integration_test plugin label Dec 10, 2020
@jiahaog jiahaog mentioned this issue Dec 10, 2020
Merged
1 task
@pedromassangocode pedromassangocode added a: tests "flutter test", flutter_test, or one of our tests passed first triage c: proposal A detailed proposal for a change to Flutter c: contributor-productivity Team-specific productivity, code health, technical debt. labels Dec 10, 2020
@darshankawar darshankawar added the framework flutter/packages/flutter repository. See also f: labels. label Apr 21, 2022
@Piinks
Copy link
Contributor

Piinks commented Jun 16, 2022

Golden file testing with Skia Gold was added to the API docs example code in #99298, following the same pattern from PR would make it fairly easy to complete this. :)

@Piinks Piinks added easy fix P3 Issues that are less important to the Flutter project labels Jun 16, 2022
@flutter-triage-bot flutter-triage-bot bot added the good first issue Relatively approachable for first-time contributors label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@Hixie Hixie removed the easy fix label Aug 4, 2023
@matanlurey matanlurey self-assigned this Nov 15, 2024
@matanlurey matanlurey mentioned this issue Nov 21, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
@matanlurey
Add a simple golden-file test to package:integration_test. (#159233)
48c2301 
Closes #72045.

Let's see if I wired this correctly and if `Flutter Gold` knows to check
based on the files changed.
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: proposal A detailed proposal for a change to Flutter f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. good first issue Relatively approachable for first-time contributors P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a simple golden-file test to package:integration_test. matanlurey/flutter
6 participants
@matanlurey @Hixie @jiahaog @Piinks @darshankawar @pedromassangocode