More beautiful linear_gradient sample #99298
Conversation
Tweaking example so that it's more attractive to a design-orientated audience
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
@Piinks @gspencergoog This is enabling goldens testing for API samples for #96491. Can you take a look if that's the correct way to do it? |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Looks like it works! 🎉 |
|
Gold has detected about 1 new digest(s) on patchset 2. |
|
@timsneath I incorporated your PR #96491 into this one and added the necessary configuration to make the golden test that you added pass. Can you LGTM this PR if you're OK with that? Otherwise, feel free to incorporate these changes into your original PR and we can submit that one. |
|
Gold has detected about 2 new digest(s) on patchset 3. |
|
@timsneath said via chat that he is okay with this moving forward in this PR. @Piinks wanna review this? |
|
Certainly! |
| const Platform platform = LocalPlatform(); | ||
| if (FlutterPostSubmitFileComparator.isAvailableForEnvironment(platform)) { | ||
| goldenFileComparator = await FlutterPostSubmitFileComparator.fromDefaultComparator(platform); | ||
| goldenFileComparator = await FlutterPostSubmitFileComparator.fromDefaultComparator(platform, namePrefix: namePrefix); |
There was a problem hiding this comment.
Oh nice. It will probably scale better to other packages to have them set a prefix in the test config file. 👍
|
This pull request is not suitable for automatic merging in its current state.
|
|
The Google failure is unrelated to this change, manually set green. |
Taking over PR #96491 and enabling golden tests for API doc sample tests to make the newly added test pass.