-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Adds StandardMessageCodec benchmark #101767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds StandardMessageCodec benchmark #101767
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Please don't mark your own PRs as test-exempt, the whole point of the process is that every PR that doesn't have tests needs to be manually checked so as to denormalize the behaviour of writing PRs without tests. |
37b3654
to
e08c996
Compare
@Hixie everything that is landed is reviewed, so it is manually checked. In the case of writing tests it seemed we could trust the author and the reviewer to make that decision and that your attention was only required in more nuanced situations. In any case, I don't think there is harm communicating the explanation. Let me know if you want to format it differently. |
@@ -0,0 +1,21 @@ | |||
// Copyright 2014 The Flutter Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file intended as part of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, was on the wrong base. Fixed.
I think for this case we should teach the bot about tests under the |
e08c996
to
7d0f0f6
Compare
test-exempt: is a test |
bb94311
to
7d0f0f6
Compare
This is a benchmark to land before I land my performance fixes.
test exempt: is a test
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.