[macOS] Use editing intents from engine #105407

knopp · 2022-06-05T18:39:40Z

Before	After

Fixes #85328

Requires flutter/engine#33838

This PR removes most of macOS specific text editing shortcut definitions and instead listens to appropriate selector messages from the engine, translating them into intents.

In order for text editing tests to work correctly, FlutterTester translates unhandled key events (only when defaultTargetPlatform == macOS and active text input) to selectors, similarly to how the engine would.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2022-06-05T18:39:43Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

knopp · 2022-06-05T18:46:02Z

Couple of issues:

There don't seem to be intents for PageUp and PageDown. Right now those are bounds to ScrollToDocumentBoundaryIntent and ExpandSelectionToDocumentBoundaryIntent, but that doesn't seem correct.
Escape key needs to be handled by the IME, which either hides the IME selection window or produces cancelOperation action if there is no IME selection window. The PR disables escape during editing (DoNothingAndStopPropagationTextIntent) and binds cancelOperation to DismissIntent.

@LongCatIsLooong, @justinmc, any thoughts?

LongCatIsLooong · 2022-06-07T17:37:41Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

@@ -461,3 +487,78 @@ class DefaultTextEditingShortcuts extends StatelessWidget {
    );
  }
 }
+
+// These constants are based on NSStandardKeyBindingResponding method names
+final Map<String, Intent> _stringToIntent = <String, Intent>{


I have a WIP pull request before we went with the isComposing hack, it's a bit more ambitious than just sending Intents from macOS: #94961. I'm still not sure if it's a good idea to turn other commands into intents, we can give this a try first.

The selector names are specific to iOS/macOS. The method call name TextInputClient.performIntent seems to be a little bit too generic for sending selector names to the framework. Or we could do the selector name -> Intent name translation in the engine.

I wasn't sure if this approach was viable, so I didn't want to spent time translating selectors to generic names. One approach would be to map selectors in engine into something more resembling intents that we have (ie. with collapse/forward attributes). I'll give it a try.

Or we can rename performIntent to performSelector. Also it's a bit strange that the intents are sent via the focus system despite that we already have an established TextInputConnection.

My gut says that the names sent from the engine should stay NSStandardKeyBindingResponding names. I imagine a developer might want to handle a specific NSStandardKeyBindingResponding command and we don't want to hide that from them. That's my thought.

Or we can rename performIntent to performSelector. Also it's a bit strange that the intents are sent via the focus system despite that we already have an established TextInputConnection.

We had a discussion about this with @matthew-carroll and he made same point. There could be performSelector method on TextInputClient, which could, if needed, translate it to an Intent and pass it to focus system. That way it would also be possible to handle selectors that Flutter is not interested in.

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

justinmc

This approach looks pretty straightfoward to me. If @LongCatIsLooong is on board with doing this for now before something like #94961 then that sounds good to me.

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

justinmc · 2022-06-07T18:52:21Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

@@ -461,3 +487,78 @@ class DefaultTextEditingShortcuts extends StatelessWidget {
    );
  }
 }
+
+// These constants are based on NSStandardKeyBindingResponding method names
+final Map<String, Intent> _stringToIntent = <String, Intent>{


My gut says that the names sent from the engine should stay NSStandardKeyBindingResponding names. I imagine a developer might want to handle a specific NSStandardKeyBindingResponding command and we don't want to hide that from them. That's my thought.

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

justinmc · 2022-06-07T18:53:00Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

+
+  'transpose': const TransposeCharactersIntent(),
+
+  // TODO(knopp): Page Up/Down intents are missing


I opened a PR for pageup/down in text editing here: #105497

justinmc · 2022-06-07T19:51:41Z

packages/flutter/lib/src/services/text_input.dart

+
+  /// Performs macOS specific selector from the NSStandardKeyBindingResponding
+  /// protocol.
+  void performSelector(String selectorName) {}


One more thing I just thought of: I want to make sure that this is something that we want to add to TextInputClient and not split out. We've been having a bunch of discussion about this topic, see this design doc: https://docs.google.com/document/d/1OxDsf_eot7TlsRn57z-1_dGbvuqnMxO7QEGIAmOCZtA/edit

LongCatIsLooong · 2022-06-13T18:05:20Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

+  // Escape when there's no IME selection
+  'cancelOperation:': const DismissIntent(),
+  // Tab when there's no IME selection
+  'insertTab:': const NextFocusIntent(),


why is insertTab mapped to focus change instead of inserting a tab to the currently focused text field?

Because that's what would happen without this PR. The NextFocusIntent action has own shortcut (_defaultShortcuts) and default text editing shortcuts don't override this. With the exception of macOS in this PR because we need to feed tab to TextInputContext.

Tab handling (and rendering) does need some work, but it feels like it is out of scope of this PR.

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

packages/flutter/test/services/text_input_test.dart

LongCatIsLooong · 2022-06-13T20:39:55Z

packages/flutter_test/lib/src/event_simulation.dart

-}) {
-  return KeyEventSimulator.simulateKeyDownEvent(key, platform: platform, physicalKey: physicalKey, character: character);
+}) async {
+  final bool handled = await KeyEventSimulator.simulateKeyDownEvent(key, platform: platform, physicalKey: physicalKey, character: character);


I'm not entirely sure we should do this. This can be used when there's no text input control present. /cc @dkwingsmt

I think we should just verify the selectors are handled correctly instead of trying to verify the key presses are handled correctly.

TestWidgetsFlutterBinding.testTextInput is not nullable. So if binding is TestWidgetsFlutterBinding the text input should be present.

The purpose of this code is to turn unhandled key events into selectors, if text input is currently active, same way FlutterTextInputPlugin does it on macOS. There are (almost) no keyboard editing/navigation shortcuts defined for macOS anymore, everything is driven by selectors, so Flutter Tester must be able to simulate the environment, otherwise most text editing tests just fail on macOS.

That said, I don't know if event_simulation is the right place to do this.

I think this process is reasonable. The entire test binding is to emulate a real device, and this new logic reflects our new model for the macOS system, which translates unhandled key events into selectors.

LongCatIsLooong · 2022-06-13T20:51:35Z

packages/flutter/lib/src/services/text_input.dart

@@ -1125,6 +1125,10 @@ abstract class TextInputClient {

  /// Requests that the client remove the text placeholder.
  void removeTextPlaceholder() {}
+
+  /// Performs macOS specific selector from the NSStandardKeyBindingResponding


If the app user has a custom selector defined in DefaultKeyBinding.Dict, the selector will be sent as-is to the framework right? So it's not necessarily from NSStandardKeyBindingResponding.

Also in DefaultKeyBinding.Dict you can remap a key to a selector + parameters. An example:

"~h" = ("insertText:", "hello word", "moveBackward:");

Also using the current primary focus seems to be a reasonable default implementation.

I don't know if AppKit would deliver completly custom selectors to doCommandBySelector:. I can try it though.

insertText: is not processed through doCommandBySelector: (and there is no argument other than selector there).

Nevermind, custom selectors are delivered. I'll update the comment.

Yeah I think it worked for me when I tried a custom selector (a random string really). But I didn't try a selector with a parameter list. The documentation I found didn't mention that either: https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/EventOverview/TextDefaultsBindings/TextDefaultsBindings.html

The signature of doCommandBySelector: only has one argument (the selector), so I don't see how parameters would work, but custom selectors certainly do.

justinmc

Some more improvements here. Thanks for following up on all this!

packages/flutter/lib/src/services/text_input.dart

justinmc · 2022-07-01T23:16:01Z

packages/flutter/lib/src/services/text_input.dart

+
+  /// Performs macOS specific selector from the `NSStandardKeyBindingResponding`
+  /// protocol or user specified selector from `DefaultKeyBinding.Dict`.
+  void performSelector(String selectorName) {}


Could this be more generic than text input? Maybe it should have its own class instead of being a part of TextInputClient?

The selector is sent from TextInputContext, which is only used through the TextInputClient.

Agreed after looking at the engine PR again.

If anyone is using TextInputClient with the implements keyword`, then they will be broken by this change. We should keep an eye out for that.

FYI here is a design doc that I wrote recently about adding platform methods. I think in this case we're all onboard with that pattern.

justinmc · 2022-07-01T23:17:37Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

+    const SingleActivator(LogicalKeyboardKey.keyZ, meta: true): const UndoTextIntent(SelectionChangedCause.keyboard),
+    const SingleActivator(LogicalKeyboardKey.keyZ, shift: true, meta: true): const RedoTextIntent(SelectionChangedCause.keyboard),
+
+    // On desktop these keys should go to the IME when a field is focused, not to other


On all desktop platforms or only on Mac?

Only on Mac (the comment is inside _macShortcuts), but not on web on mac (hence "desktop").

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

justinmc · 2022-07-01T23:21:29Z

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

+    'pageUpAndModifySelection': ExpandSelectionToDocumentBoundaryIntent(forward: false),
+    'pageDownAndModifySelection:': ExpandSelectionToDocumentBoundaryIntent(forward: true),
+
+    // Escape when there's no IME selection


Period at the end.

By "no IME selection" do you mean no field is focused or no TextEditingValue.selection is collapsed?

I meant the IME candidate selection popup. When there is a popup TextInputContext will eat the escape key (hiding the popup). If there is no popup, TextInputContext will produce cancelOperation: selector, which we map to DismissIntent.

packages/flutter/lib/src/widgets/default_text_editing_shortcuts.dart

packages/flutter/lib/src/widgets/editable_text.dart

justinmc

LGTM 👍

Probably should let @LongCatIsLooong give a final review as well.

packages/flutter/lib/src/services/text_input.dart

justinmc · 2022-07-11T16:58:53Z

packages/flutter/lib/src/services/text_input.dart

+
+  /// Performs macOS specific selector from the `NSStandardKeyBindingResponding`
+  /// protocol or user specified selector from `DefaultKeyBinding.Dict`.
+  void performSelector(String selectorName) {}


Agreed after looking at the engine PR again.

If anyone is using TextInputClient with the implements keyword`, then they will be broken by this change. We should keep an eye out for that.

FYI here is a design doc that I wrote recently about adding platform methods. I think in this case we're all onboard with that pattern.

dkwingsmt · 2022-07-20T14:01:00Z

packages/flutter_test/lib/src/test_text_input_key_handler.dart

+        key == LogicalKeyboardKey.metaLeft ||
+        key == LogicalKeyboardKey.metaRight) {
+      _meta = true;
+    } else {


Why no controls?

Seems like an oversight. Also this should have caught by tests. I'll look into this.

Indeed, control was missing :-/ The transpose test didn't fail, because, because Control+T did result in transpose: selector selector. The issue is that without checking for control Just T itself would result in transpose: as well. Fixed.

dkwingsmt · 2022-07-20T14:11:32Z

packages/flutter_test/lib/src/event_simulation.dart

-}) {
-  return KeyEventSimulator.simulateKeyDownEvent(key, platform: platform, physicalKey: physicalKey, character: character);
+}) async {
+  final bool handled = await KeyEventSimulator.simulateKeyDownEvent(key, platform: platform, physicalKey: physicalKey, character: character);


I think this process is reasonable. The entire test binding is to emulate a real device, and this new logic reflects our new model for the macOS system, which translates unhandled key events into selectors.

dkwingsmt · 2022-07-20T14:12:11Z

The change LGTM except for the one question.

dkwingsmt · 2022-07-29T07:38:14Z

This PR will need flutter/engine#33838 to be rolled into flutter/flutter to avoid breaking. This might take a few days.

tgucio · 2022-07-29T08:54:51Z

@dkwingsmt This should be aready in (#108602 merged).

dkwingsmt · 2022-07-29T11:09:58Z

@tgucio That was way faster than my past experience! Thanks for letting me know.

dkwingsmt · 2022-08-01T23:28:41Z

Is this PR ready to go? Shall we add auto-submit to it?

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (#108744) * Fix lerp to eccentric circle. (#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (#108751) * Sync with flutter/.github#13 (#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (#108755) * clean-up analysis_options.yaml (#108747) * Fix ExpansionTile shows children background when expanded (#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (#108757) * Enable conditional_uri_does_not_exist (#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (#108466) (#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (#108825) * Loupe Android + iOS (#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (#108820) * Deprecate `toggleableActiveColor` (#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (#108833) * fix noop toString() diagnostics (#108836) * [flutter_tools] Migrate more tool tests to null-safety (#108639) * Revert "Fix ExpansionTile shows children background when expanded" (#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (#104088) * Update documentation to match implementation (#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." #108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (#108862)" (#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (#108899) * [flutter_test] Add flag to send device pointer events to the framework (#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (#108903) * fix flutter not finding custom device (#108884) * Force a11y services to off for complex_layout_semantics_perf test (#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (#108507) * [macOS] Use editing intents from engine (#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (#108776) * Roll pub packages (#108919) * [flutter_test] perf: find.ancestor (#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (#108923) * Remove some outdated ignores from framework (#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (#108925) * Clean up ScrollbarPainter (#107179) * Remove outdated ignores (#108924) * Add more logs to diagnose Gold flake (#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Tomasz Gucio <[email protected]> Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: Ian Hickson <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: pdblasi-google <[email protected]> Co-authored-by: Kaushik Iska <[email protected]> Co-authored-by: xubaolin <[email protected]> Co-authored-by: Anthony Oleinik <[email protected]> Co-authored-by: keyonghan <[email protected]> Co-authored-by: Taha Tesser <[email protected]> Co-authored-by: Danny Tuppeny <[email protected]> Co-authored-by: Phil Quitslund <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: parkershepherd <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Jia Hao <[email protected]> Co-authored-by: Hannes Winkler <[email protected]> Co-authored-by: Matej Knopp <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: David Iglesias <[email protected]> Co-authored-by: Pascal Welsch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* M3 counter error style * polish * Update text_field_template.dart * Roll Flutter Engine from 3cba105 to cf0db3e (1 revision) (flutter#108716) * resolve comments * Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (flutter#108738) * Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (flutter#108623) * Roll Flutter Engine from cf0db3e to aa90044 (1 revision) (flutter#108734) * Roll Flutter Engine from aa90044 to 6d2fd23 (5 revisions) (flutter#108744) * Fix lerp to eccentric circle. (flutter#108743) * Roll Flutter Engine from 6d2fd23 to f182794 (4 revisions) (flutter#108749) * Roll Flutter Engine from f182794 to 25e8021 (1 revision) (flutter#108751) * Sync with flutter/.github#13 (flutter#108754) * Roll Flutter Engine from 25e8021 to e771729 (2 revisions) (flutter#108755) * clean-up analysis_options.yaml (flutter#108747) * Fix ExpansionTile shows children background when expanded (flutter#107834) * Create `containsSemantics` to allow for partial matching of semantics in tests. (flutter#108573) * Roll Flutter Engine from e771729 to 7d0f6d2 (2 revisions) (flutter#108757) * Enable conditional_uri_does_not_exist (flutter#108652) * Roll Flutter Engine from 7d0f6d2 to b257966 (3 revisions) (flutter#108763) * Roll Flutter Engine from b257966 to 60e5eb6 (3 revisions) (flutter#108766) * Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (flutter#108466) (flutter#108769) * [SelectionOverlay]Move the debug statement to the scope of the assertion. (flutter#108508) * Roll Flutter Engine from 60e5eb6 to 1c3b1b3 (11 revisions) (flutter#108780) * Roll Flutter Engine from 1c3b1b3 to b607811 (1 revision) (flutter#108782) * Roll Flutter Engine from b607811 to 3b2bd24 (1 revision) (flutter#108784) * Roll Flutter Engine from 3b2bd24 to 0e5392c (1 revision) (flutter#108788) * Roll Flutter Engine from 0e5392c to 4b19256 (1 revision) (flutter#108793) * Roll Flutter Engine from 4b19256 to e0b5edc (2 revisions) (flutter#108798) * Roll Flutter Engine from e0b5edc to b164c5c (1 revision) (flutter#108814) * Update text_field.dart * Roll Flutter Engine from b164c5c to eb2b57b (4 revisions) (flutter#108821) * Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (flutter#108822) * Roll Flutter Engine from eb2b57b to 978d8e2 (2 revisions) (flutter#108825) * Loupe Android + iOS (flutter#107477) * added Magnifier for iOS and Android * Mark `Mac_ios microbenchmarks_ios_flaky` flaky (flutter#108820) * Deprecate `toggleableActiveColor` (flutter#97972) * Roll Flutter Engine from 978d8e2 to 2b31732 (4 revisions) (flutter#108830) * [flutter_tools] Test that DAP process terminates at the end of a session (flutter#108301) * Roll Flutter Engine from 2b31732 to 4e9c869 (1 revision) (flutter#108833) * fix noop toString() diagnostics (flutter#108836) * [flutter_tools] Migrate more tool tests to null-safety (flutter#108639) * Revert "Fix ExpansionTile shows children background when expanded" (flutter#108844) * Roll Flutter Engine from 4e9c869 to 6724561 (2 revisions) (flutter#108838) * Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (flutter#104088) * Update documentation to match implementation (flutter#108843) * Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." flutter#108718 * Roll Flutter Engine from 6724561 to f3deaba (8 revisions) (flutter#108847) * Roll Flutter Engine from f3deaba to c07e1ac (2 revisions) (flutter#108849) * Roll Flutter Engine from c07e1ac to a1e77ae (5 revisions) (flutter#108850) * Roll Flutter Engine from a1e77ae to c456476 (2 revisions) (flutter#108853) * Roll Flutter Engine from c456476 to 6cd744b (1 revision) (flutter#108857) * Roll Flutter Engine from 6cd744b to 51296a6 (1 revision) (flutter#108860) * Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862) * Revert "Roll Flutter Engine from 51296a6 to 05228ad (1 revision) (flutter#108862)" (flutter#108882) This reverts commit a880c4e. * Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (flutter#108887) * Roll Flutter Engine from 51296a6 to 2c28298 (6 revisions) (flutter#108899) * [flutter_test] Add flag to send device pointer events to the framework (flutter#108430) * Roll Flutter Engine from 2c28298 to adba702 (2 revisions) (flutter#108903) * fix flutter not finding custom device (flutter#108884) * Force a11y services to off for complex_layout_semantics_perf test (flutter#108906) * Update `equalsIgnoringHashCodes` to take a list of Strings (flutter#108507) * [macOS] Use editing intents from engine (flutter#105407) * Added `IconButtonTheme` and apply it to `IconButton` in M3 (flutter#108332) * Created IconButtonTheme and apply it to IconButton * [web] Add onEntrypointLoaded to FlutterLoader. (flutter#108776) * Roll pub packages (flutter#108919) * [flutter_test] perf: find.ancestor (flutter#108868) * Roll Flutter Engine from adba702 to 1188a80 (4 revisions) (flutter#108922) * Bump github/codeql-action from 2.1.17 to 2.1.18 (flutter#108923) * Remove some outdated ignores from framework (flutter#108915) * Roll Flutter Engine from 1188a80 to 1743d1d (1 revision) (flutter#108925) * Clean up ScrollbarPainter (flutter#107179) * Remove outdated ignores (flutter#108924) * Add more logs to diagnose Gold flake (flutter#108930) * M3 counter error style * polish * Update text_field_template.dart * resolve comments * Update text_field.dart Co-authored-by: engine-flutter-autoroll <[email protected]> Co-authored-by: Tomasz Gucio <[email protected]> Co-authored-by: Greg Spencer <[email protected]> Co-authored-by: Ian Hickson <[email protected]> Co-authored-by: Michael Goderbauer <[email protected]> Co-authored-by: Bruno Leroux <[email protected]> Co-authored-by: pdblasi-google <[email protected]> Co-authored-by: Kaushik Iska <[email protected]> Co-authored-by: xubaolin <[email protected]> Co-authored-by: Anthony Oleinik <[email protected]> Co-authored-by: keyonghan <[email protected]> Co-authored-by: Taha Tesser <[email protected]> Co-authored-by: Danny Tuppeny <[email protected]> Co-authored-by: Phil Quitslund <[email protected]> Co-authored-by: Christopher Fujino <[email protected]> Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Flutter GitHub Bot <[email protected]> Co-authored-by: parkershepherd <[email protected]> Co-authored-by: Darren Austin <[email protected]> Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Jia Hao <[email protected]> Co-authored-by: Hannes Winkler <[email protected]> Co-authored-by: Matej Knopp <[email protected]> Co-authored-by: Qun Cheng <[email protected]> Co-authored-by: David Iglesias <[email protected]> Co-authored-by: Pascal Welsch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

## Description This PR fixes a focus traversal issue for read-only TextField on macOS. # Implementation details On macOS, some editing capabilities are handled differently compared to other platforms. Since #105407, the macOS engine send editing selectors to the framework. To do so a text input connection should be opened. Before this PR there was no text input connection for a read-only EditableText which means several shortcut were not handled, especially tab traversal (but also selection shortcuts using arrows). After this PR an input connection is always created on macOS even if an EditableText is read-only. ## Related Issue Fixes [Read-only TextField prevents focus from changing](#161482) ## Tests Adds 1 test.

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 5, 2022

knopp mentioned this pull request Jun 5, 2022

Can't navigate composing candidates list with arrow keys on Mac #85328

Closed

LongCatIsLooong reviewed Jun 7, 2022

View reviewed changes

justinmc reviewed Jun 7, 2022

View reviewed changes

knopp force-pushed the macos_use_editing_intents_from_engine branch 3 times, most recently from 2c1a76f to a0d6616 Compare June 9, 2022 14:56

knopp mentioned this pull request Jun 9, 2022

[macOS] Remove isComposing workaround flutter/engine#33838

Merged

8 tasks

knopp force-pushed the macos_use_editing_intents_from_engine branch from c43f8c1 to a5c8b35 Compare June 11, 2022 18:39

flutter-dashboard bot added the a: tests "flutter test", flutter_test, or one of our tests label Jun 12, 2022

knopp changed the title ~~WIP: [macOS] Use editing intents from engine~~ [macOS] Use editing intents from engine Jun 12, 2022

knopp force-pushed the macos_use_editing_intents_from_engine branch from 33f4768 to 7466b87 Compare June 13, 2022 14:28

LongCatIsLooong reviewed Jun 13, 2022

View reviewed changes

knopp force-pushed the macos_use_editing_intents_from_engine branch 2 times, most recently from ea6c7f6 to 160eceb Compare June 15, 2022 10:53

goderbauer requested review from LongCatIsLooong and justinmc June 29, 2022 21:46

justinmc reviewed Jul 1, 2022

View reviewed changes

knopp force-pushed the macos_use_editing_intents_from_engine branch from 4b7fa08 to 1897d1f Compare July 5, 2022 13:20

justinmc approved these changes Jul 11, 2022

View reviewed changes

knopp force-pushed the macos_use_editing_intents_from_engine branch from 606008c to 1f1a33d Compare July 14, 2022 12:18

dkwingsmt reviewed Jul 20, 2022

View reviewed changes

knopp changed the title ~~[macOS] Use editing intents from engine~~ WIP: [macOS] Use editing intents from engine Jul 28, 2022

Use editing intents from engine

07aaf53

knopp added 8 commits July 28, 2022 22:09

Update comment

ca8b0dd

Period

3b938fa

Import foundation for kIsWeb

e66caf3

Update comment

54a613f

Update comment

06077e5

Update comment

ab642d5

Fix comment

85073b6

Disable meta-arrow shortcuts

3310569

knopp force-pushed the macos_use_editing_intents_from_engine branch from 1f1a33d to 3310569 Compare July 28, 2022 20:09

Simulate control

79895d0

knopp changed the title ~~WIP: [macOS] Use editing intents from engine~~ [macOS] Use editing intents from engine Jul 28, 2022

LongCatIsLooong approved these changes Aug 1, 2022

View reviewed changes

knopp merged commit 7e8f0e5 into flutter:master Aug 3, 2022

knopp deleted the macos_use_editing_intents_from_engine branch August 3, 2022 19:51

engine-flutter-autoroll mentioned this pull request Aug 4, 2022

Roll Flutter from 183d3e410102 to 74aef9ff8786 (27 revisions) flutter/plugins#6203

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 4, 2022

7e8f0e5 [macOS] Use editing intents from engine (flutter/flutter#105407)

be85ddb

engine-flutter-autoroll mentioned this pull request Aug 4, 2022

Roll Flutter from 183d3e410102 to 74aef9ff8786 (27 revisions) flutter/packages#2412

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2022

7e8f0e5 [macOS] Use editing intents from engine (flutter/flutter#105407)

2a5f500

engine-flutter-autoroll mentioned this pull request Aug 4, 2022

Roll Flutter from 183d3e410102 to c22b7f697fc8 (28 revisions) flutter/packages#2414

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2022

7e8f0e5 [macOS] Use editing intents from engine (flutter/flutter#105407)

c22d6c5

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

[macOS] Use editing intents from engine (flutter#105407)

df787d1

dnfield mentioned this pull request Oct 20, 2022

Delete super_editor.test flutter/tests#165

Merged

bleroux mentioned this pull request Mar 27, 2025

Fix read only TextField focus traversal on macOS #166056

Merged


		'transpose': const TransposeCharactersIntent(),

		// TODO(knopp): Page Up/Down intents are missing

[macOS] Use editing intents from engine #105407

[macOS] Use editing intents from engine #105407

Uh oh!

Conversation

knopp commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 5, 2022

Uh oh!

knopp commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knopp Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knopp Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knopp Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knopp Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knopp Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

knopp commented Jun 5, 2022 •

edited

Loading

knopp commented Jun 5, 2022 •

edited

Loading

knopp Jun 7, 2022 •

edited

Loading

knopp Jun 13, 2022 •

edited

Loading

knopp Jun 13, 2022 •

edited

Loading

knopp Jun 13, 2022 •

edited

Loading

LongCatIsLooong Jun 13, 2022 •

edited

Loading

knopp Jun 13, 2022 •

edited

Loading