Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use [Intent]s to send text input plugin commands to text fields #94961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

LongCatIsLooong
Copy link
Contributor

Fixes #30725 #85328

  • Introduces a new TextInputConnection type that dispatches text input plugin commands in the form of Intents to Flutter text fields, as an alternative to the current TextInputClient approach. This allows text input plugin authors to add new capabilities to Flutter text fields without having to update a static interface (currently all capabilities have to be added to the TextInputClient interface and it's always a breaking change to add a new one). See https://docs.google.com/document/d/1pNM7Ay3NkIBjE0jIY-c41OdtSc9bv_izO7xJ9OrAT5E/edit
  • Removes framework-defined macOS shortcuts. The macOS text input plugin will let the system handle shortcuts/keybindings, and convert selector names retrieved in doCommandBySelector: to framework intents, and send the intents via IntentTextInputConnection.

Future Plans

  • deprecate TextInputClient and DeltaTextInputClient.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 9, 2021
@christopherfujino
Copy link
Contributor

@LongCatIsLooong I'm closing this as stale. Feel free to re-open if you want to actually land it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add desktop shell support for text navigation key combinations
2 participants