Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate Linux android gallery e2e and hybrid tests to build+test #110533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 7, 2022
Merged

Migrate Linux android gallery e2e and hybrid tests to build+test #110533

merged 6 commits into from
Sep 7, 2022

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Aug 29, 2022 •
edited
Loading

Part of #103542.

This migrates flutter_gallery__transition_perf_hybrid and flutter_gallery__transition_perf_e2e to build+test model. Validated via led, but marking as bringup: true to initiate in CI.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 29, 2022
@keyonghan keyonghan marked this pull request as draft August 29, 2022 21:06
@keyonghan keyonghan mentioned this pull request Aug 30, 2022
Closed
@keyonghan keyonghan changed the title Migrate other Linux android gallery tests to build+test Migrate Linux android gallery e2e and hybrid tests to build+test Aug 30, 2022
@keyonghan keyonghan marked this pull request as ready for review August 30, 2022 20:36
zanderso
zanderso requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the recipe hit a bug today, I'd rather hold on this until the one benchmark that is currently under build_test can successfully be promoted out of bringup.

@keyonghan
Copy link
Contributor Author

Given that the recipe hit a bug today, I'd rather hold on this until the one benchmark that is currently under build_test can successfully be promoted out of bringup.

Target flutter_gallery__transition_perf is in prod, and this is unblocked.

@zanderso
Copy link
Member

zanderso commented Sep 1, 2022

@keyonghan Since the build_test changes started landing, it looks like we haven't been getting flutter_gallery__transition_perf benchmark numbers reported to SkiaPerf for Moto G4 for the past two days: https://flutter-flutter-perf.skia.org/e/?begin=1661456541&end=1661992145&queries=test%3Dflutter_gallery__transition_perf&requestType=0

Could you please take a look?

@keyonghan
Copy link
Contributor Author

Thanks @zanderso for catching this. I validated the metrics when it ran in staging, but missed it when moved to prod. Working on a patch.

@keyonghan keyonghan mentioned this pull request Sep 1, 2022
Closed
@keyonghan
Copy link
Contributor Author

Now the target flutter_gallery__transition_perf in running in prod, and performance metrics are being populated correctly:
https://flutter-flutter-perf.skia.org/e/?queries=test%3Dflutter_gallery__transition_perf
We should be good now /cc @zanderso

zanderso
zanderso reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of unrelated formatting changes in this PR that don't seem to be in alignment with the style guide. I'd suggest backing those out.

dev/devicelab/lib/tasks/gallery.dart Outdated
testFile: semanticsEnabled
? 'transitions_perf_e2e_with_semantics'
: 'transitions_perf_e2e',
testFile: semanticsEnabled ? 'transitions_perf_e2e_with_semantics' : 'transitions_perf_e2e',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the formatting change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I formatted locally with 120 length.. Restored back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flutter/flutter repo doesn't use the Dart formatter for formatting, so you might want to make sure you have it turned off in your IDE when working there.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit ab77e43 into flutter:master Sep 7, 2022
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
ab77e43 Migrate Linux android gallery e2e and hybrid tests to bui…
2fe3390 
…ld+test (flutter/flutter#110533)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
ab77e43 Migrate Linux android gallery e2e and hybrid tests to bui…
0dc10f5 
…ld+test (flutter/flutter#110533)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
ab77e43 Migrate Linux android gallery e2e and hybrid tests to bui…
1bb36cc 
…ld+test (flutter/flutter#110533)
@keyonghan keyonghan mentioned this pull request Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@godofredoc godofredoc Awaiting requested review from godofredoc

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keyonghan @zanderso @CaseyHillers