Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate Linux android gallery e2e and hybrid tests to build+test #110533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Migrate Linux android gallery e2e and hybrid tests to build+test #110533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a580a1f
e2e to build+test
keyonghan Aug 29, 2022
2b90afb
no-dds
keyonghan Aug 29, 2022
9a095ff
hybrid build+test
keyonghan Aug 29, 2022
049408a
update ci.yaml config
keyonghan Aug 30, 2022
7f0242f
restore format
keyonghan Sep 7, 2022
f09e8fe
remove format change
keyonghan Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1940,25 +1940,29 @@ targets:
tags: >
["devicelab", "android", "linux"]
task_name: flutter_gallery__transition_perf
artifact: gallery_app_profile
artifact: gallery__transition_perf

- name: Linux_android flutter_gallery__transition_perf_e2e
recipe: devicelab/devicelab_drone
- name: Linux_build_test flutter_gallery__transition_perf_e2e
recipe: devicelab/devicelab_drone_build_test
bringup: true # New target https://github.com/flutter/flutter/issues/103542
presubmit: false
timeout: 60
properties:
tags: >
["devicelab", "android", "linux"]
task_name: flutter_gallery__transition_perf_e2e
artifact: gallery__transition_perf_e2e

- name: Linux_android flutter_gallery__transition_perf_hybrid
recipe: devicelab/devicelab_drone
- name: Linux_build_test flutter_gallery__transition_perf_hybrid
recipe: devicelab/devicelab_drone_build_test
bringup: true # New target https://github.com/flutter/flutter/issues/103542
presubmit: false
timeout: 60
properties:
tags: >
["devicelab", "android", "linux"]
task_name: flutter_gallery__transition_perf_hybrid
artifact: gallery__transition_perf_hybrid

- name: Linux_android flutter_gallery__transition_perf_with_semantics
recipe: devicelab/devicelab_drone
Expand Down
4 changes: 2 additions & 2 deletions dev/devicelab/bin/tasks/flutter_gallery__transition_perf_e2e.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/gallery.dart';

Future<void> main() async {
Future<void> main(List<String> args) async {
deviceOperatingSystem = DeviceOperatingSystem.android;
await task(createGalleryTransitionE2ETest());
await task(createGalleryTransitionE2EBuildTest(args));
}
4 changes: 2 additions & 2 deletions dev/devicelab/bin/tasks/flutter_gallery__transition_perf_hybrid.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/gallery.dart';

Future<void> main() async {
Future<void> main(List<String> args) async {
deviceOperatingSystem = DeviceOperatingSystem.android;
await task(createGalleryTransitionHybridTest());
await task(createGalleryTransitionHybridBuildTest(args));
}
32 changes: 32 additions & 0 deletions dev/devicelab/lib/tasks/gallery.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,23 @@ TaskFunction createGalleryTransitionTest({bool semanticsEnabled = false}) {
return GalleryTransitionTest(semanticsEnabled: semanticsEnabled);
}

TaskFunction createGalleryTransitionE2EBuildTest(
List<String> args, {
bool semanticsEnabled = false,
bool enableImpeller = false,
}) {
return GalleryTransitionBuildTest(
args,
testFile: semanticsEnabled ? 'transitions_perf_e2e_with_semantics' : 'transitions_perf_e2e',
needFullTimeline: false,
timelineSummaryFile: 'e2e_perf_summary',
transitionDurationFile: null,
timelineTraceFile: null,
driverFile: 'transitions_perf_e2e_test',
enableImpeller: enableImpeller,
);
}

TaskFunction createGalleryTransitionE2ETest({
bool semanticsEnabled = false,
bool enableImpeller = false,
Expand All @@ -42,6 +59,17 @@ TaskFunction createGalleryTransitionE2ETest({
);
}

TaskFunction createGalleryTransitionHybridBuildTest(
List<String> args, {
bool semanticsEnabled = false,
}) {
return GalleryTransitionBuildTest(
args,
semanticsEnabled: semanticsEnabled,
driverFile: semanticsEnabled ? 'transitions_perf_hybrid_with_semantics_test' : 'transitions_perf_hybrid_test',
);
}

TaskFunction createGalleryTransitionHybridTest({bool semanticsEnabled = false}) {
return GalleryTransitionTest(
semanticsEnabled: semanticsEnabled,
Expand Down Expand Up @@ -205,12 +233,14 @@ class GalleryTransitionBuildTest extends BuildTestTask {
this.driverFile,
this.measureCpuGpu = true,
this.measureMemory = true,
this.enableImpeller = false,
}) : super(workingDirectory: galleryDirectory);

final bool semanticsEnabled;
final bool needFullTimeline;
final bool measureCpuGpu;
final bool measureMemory;
final bool enableImpeller;
final String testFile;
final String timelineSummaryFile;
final String? timelineTraceFile;
Expand Down Expand Up @@ -246,7 +276,9 @@ class GalleryTransitionBuildTest extends BuildTestTask {
List<String> getTestArgs(DeviceOperatingSystem deviceOperatingSystem, String deviceId) {
final String testDriver = driverFile ?? (semanticsEnabled ? '${testFile}_with_semantics_test' : '${testFile}_test');
return <String>[
'--no-dds',
'--profile',
if (enableImpeller) '--enable-impeller',
if (needFullTimeline) '--trace-startup',
'-t',
'test_driver/$testFile.dart',
Expand Down